[issue14533] Modify regrtest to make test_main optional

2012-04-09 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue14533] Modify regrtest to make test_main optional

2012-04-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset eff551437abd by R David Murray in branch 'default': #14533: if a test has no test_main, use loadTestsFromModule. http://hg.python.org/cpython/rev/eff551437abd -- nosy: +python-dev ___ Python tracker

[issue14533] Modify regrtest to make test_main optional

2012-04-08 Thread R. David Murray
R. David Murray added the comment: I can't imagine when you'd *not* want setUpModule/tearDownModule to run, so that's a reasonable conversion path. The other path for reap_children and reap_threads would be to apply them to the individual classes that require them within the test module. Wh

[issue14533] Modify regrtest to make test_main optional

2012-04-08 Thread Michael Foord
Michael Foord added the comment: Looks good to me. Note that if module level setup and teardown is needed for running tests then it should be possible to do this with setUpModule and tearDownModule functions (unless those should *only* be done when running under regrtest). -- __

[issue14533] Modify regrtest to make test_main optional

2012-04-08 Thread R. David Murray
New submission from R. David Murray : The attached patch makes 'test_main' optional for stdlib tests. If a test module does not have a 'test_main', regrtest will use the unittest loadTestsFromModule loader to load the tests. This moves us further in the direction of using normal unittest faci