[issue1449] make msi work the vs 2005(MSVC8)

2007-11-18 Thread Christian Heimes
Christian Heimes added the comment: Martin v. Löwis wrote: > Martin v. Löwis added the comment: > > Did you test the change for VS 2003? In my MSMDir > (C:\Programme\Gemeinsame Dateien\Merge Modules), I only have the > following files > > GDIPlus.msm > msmask32_X86.msm > msmask32_X86_ENU.msm >

[issue1449] make msi work the vs 2005(MSVC8)

2007-11-18 Thread Martin v. Löwis
Martin v. Löwis added the comment: Did you test the change for VS 2003? In my MSMDir (C:\Programme\Gemeinsame Dateien\Merge Modules), I only have the following files GDIPlus.msm msmask32_X86.msm msmask32_X86_ENU.msm VB_Control_mschart_RTL_X86_---.msm VB_Control_mschart_RTL_X86_ENU.msm VC_User_AT

[issue1449] make msi work the vs 2005(MSVC8)

2007-11-18 Thread Christian Heimes
Christian Heimes added the comment: I've used parts of the patch for the MSI fix for VS 2008. I've got most of the VS 2008 related changes done. Have a look. -- resolution: -> wont fix status: open -> closed __ Tracker <[EMAIL PROTECTED]>

[issue1449] make msi work the vs 2005(MSVC8)

2007-11-15 Thread Martin v. Löwis
Martin v. Löwis added the comment: One issue that also needs discussion is the structure of the build directory. It could temporarily be PCbuild9, but in the long run, it should replace PCbuild. Apart from that, the issue is whether there should be a flat structure as it is currently in PCbuild,

[issue1449] make msi work the vs 2005(MSVC8)

2007-11-15 Thread Christian Heimes
Christian Heimes added the comment: Weck, if you like to help and spend some time on getting VS2008 support into Python 2.6 and 3.0 I'm willing to assist you. You can download the Beta 2 of the VS C++ 2008 Express Edition from http://msdn2.microsoft.com/en-us/express/future/bb421473.aspx IMHO t

[issue1449] make msi work the vs 2005(MSVC8)

2007-11-15 Thread Martin v. Löwis
Martin v. Löwis added the comment: I'm opposed to this patch. Any change to the MSI build process should only be made when/after the default compiler for Python is changed. That needs to be discussed on python-dev first, and I hope that the new build infrastructure will *not* use the PCbuild8 dir

[issue1449] make msi work the vs 2005(MSVC8)

2007-11-15 Thread Christian Heimes
Christian Heimes added the comment: The patch looks fine but I've a small request. Could you please use a global var PCBUILD instead of "PCBuild" / "PCBuild8" and change the dependencies to use either MSVCR 71 or 80 depending on the content of the var. This way the msi module can handle both vers

[issue1449] make msi work the vs 2005(MSVC8)

2007-11-15 Thread Christian Heimes
Christian Heimes added the comment: I'm resetting the target version of all your MSVC patches to 2.6 + 3.0. While we can't alter the compiler version of Python 2.5 I really like to update to a new compiler for 2.6 and 3.0. -- components: +Demos and Tools, Installation keywords: +patch no

[issue1449] make msi work the vs 2005(MSVC8)

2007-11-15 Thread zouguangxian
New submission from zouguangxian: with vs 2003, msi.py get msvcr71.dll from msm. but with vs 2005, It's better to extract msvcr80.dll from %VCINTALLDIR%\redist\x86 \Microsoft.VC80.CRT\. In addition, it seems to extract file from Microsoft_VC80_CRT_x86.msm need upgrade MSI to 3.1, i am not sure.