[issue14435] Remove special block allocation from floatobject.c

Roundup Robot added the comment: New changeset 10fcaf5903e6 by Kristján Valur Jónsson in branch 'default': Issue #14435: Add Misc/NEWS and Misc/ACKS http://hg.python.org/cpython/rev/10fcaf5903e6 -- ___ Python tracker

[issue14435] Remove special block allocation from floatobject.c

Kristján Valur Jónsson added the comment: All done. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python

[issue14435] Remove special block allocation from floatobject.c

Roundup Robot added the comment: New changeset 37ebe64d39d2 by Kristján Valur Jónsson in branch 'default': Issue #14435: Remove special block allocation code from floatobject.c http://hg.python.org/cpython/rev/37ebe64d39d2 -- nosy: +python-dev ___ Py

[issue14435] Remove special block allocation from floatobject.c

Antoine Pitrou added the comment: > Here is a new patch, with the suggested changes. The variable names > and macros are similarly named as those for other objects such as > lists. Looks good to me. -- ___ Python tracker

[issue14435] Remove special block allocation from floatobject.c

Changes by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue14435] Remove special block allocation from floatobject.c

Kristján Valur Jónsson added the comment: Here is a new patch, with the suggested changes. The variable names and macros are similarly named as those for other objects such as lists. -- Added file: http://bugs.python.org/file25071/nofreelist.patch

[issue14435] Remove special block allocation from floatobject.c

Antoine Pitrou added the comment: > Do you think I should add a counter to support that functionality? I > ´d rather change it to be the size of the old freelist, similar to > PyTuple_ClearFreeList(). It should be the size of the old freelist, indeed. -- _

[issue14435] Remove special block allocation from floatobject.c

Kristján Valur Jónsson added the comment: Correction: The number returned was the number of floats in existence, not the size of the freelist. Do you think I should add a counter to support that functionality? I´d rather change it to be the size of the old freelist, similar to PyTuple_Clea

[issue14435] Remove special block allocation from floatobject.c

Antoine Pitrou added the comment: > Yes, it is supposed to, but no one is actually looking at that value. > It was used in debugging information during PyFloat_Fini() which is no > longer relevant if this block information is removed. Still, let's honour the API rather than break it. > Here's

[issue14435] Remove special block allocation from floatobject.c

Kristján Valur Jónsson added the comment: Yes, it is supposed to, but no one is actually looking at that value. It was used in debugging information during PyFloat_Fini() which is no longer relevant if this block information is removed. Sure, 100 or 10 does not matter, I see 100 being used i

[issue14435] Remove special block allocation from floatobject.c

Antoine Pitrou added the comment: One thing: PyFloat_ClearFreeList() is supposed to return the number of objects previously in the freelist, not zero. Also, perhaps 10 is a bit on the small side for the number of objects kept on the freelist. 100 instead? Or do you think that's too large? ---

[issue14435] Remove special block allocation from floatobject.c

New submission from Kristján Valur Jónsson : floatobject.c has its own block allocator. This appears to be ancient, from before the time when obmalloc.c was invented. This patch removes this allocator and puts an upper limit on the freelist of floats. The purpose of this is to reduce memory f