[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Nadeem Vawda added the comment: Hmm, so actually most of the bugs fixed in 2.7 and 3.2 weren't present in 3.3 and 3.4, and those versions already had tests equivalent to the tests I added for 2.7/3.2. As for the changes that I did make to 3.3/3.4: - two of the three cover cases that only occur

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Nadeem Vawda added the comment: An oversight on my part, I think. I'll add tests for 3.x this weekend. -- status: closed -> open ___ Python tracker ___ __

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Benjamin Peterson added the comment: Why does only 2.7 have tests? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Nadeem Vawda added the comment: All fixed, along with some other similar but harder-to-trigger bugs. Thanks for the bug report, Laurent! -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Roundup Robot added the comment: New changeset f03a335621ce by Nadeem Vawda in branch '2.7': Issue #14398: Fix size truncation and overflow bugs in bz2 module. http://hg.python.org/cpython/rev/f03a335621ce -- ___ Python tracker

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Nadeem Vawda added the comment: I'm working on it now. Will push in the next 15 minutes or so. -- ___ Python tracker ___ ___ Python-bu

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Serhiy Storchaka added the comment: What about 2.7? -- nosy: +serhiy.storchaka versions: +Python 3.3, Python 3.4 ___ Python tracker ___ __

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Roundup Robot added the comment: New changeset ebb8c7d79f52 by Nadeem Vawda in branch '3.2': Issue #14398: Fix size truncation and overflow bugs in bz2 module. http://hg.python.org/cpython/rev/ebb8c7d79f52 New changeset 25fdf297c077 by Nadeem Vawda in branch '3.3': Merge #14398: Fix size truncat

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Nadeem Vawda added the comment: That's fine by me, then. Sorry for the confusion. -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Martin v. Löwis added the comment: Nadeem: the final release candidate of 2.7.3 was already made. Any further change would require another release candidate, which in turn would delay the release further. This has to wait for 2.7.4. -- ___ Python t

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Nadeem Vawda added the comment: No, it's been around since at least 2.6. I wasn't really sure what the protocol was for bugs found during the RC process. It'd be nice to get a fix for this into 2.7.3 (and 3.2.3), but it's not urgent. -- priority: release blocker -> normal _

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Benjamin Peterson added the comment: This isn't a regression, is it? If it's not, I don't think it's essential to get into 2.7.3. -- ___ Python tracker ___

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Nadeem Vawda added the comment: This should be fixed for 2.7.3. I'll have a patch ready in the next day or two. -- nosy: +benjamin.peterson, georg.brandl priority: normal -> release blocker ___ Python tracker

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Changes by Nadeem Vawda : -- versions: +Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Nadeem Vawda added the comment: (the contents of the input file don't matter; I just pulled out a bunch of zeros from /dev/zero and compressed them with bzip2.) -- ___ Python tracker __

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Nadeem Vawda added the comment: I have been able to reproduce it; see attached script. It happens for inputs of 2GB (decompressed), but not for ones of 1GB. It seems that bz2module.c doesn't guard against 32-bit overflows when handling the size of the decompressed data. This affects both the BZ

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Laurent Gautier added the comment: Wow! Quick follow-up. The data file is about 1.6Gb. Is there a preferred way to pass it on (I suspect that the bug tracker is not the preferred way). The code goes like: import bz2 f = file("foobar.bz2", mode="rb") src_buf = f.read() decomp = bz2.BZ2Decomp

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

Martin v. Löwis added the comment: I can't reproduce this. Can you please provide a test script along with input data that allows us to reproduce this error? -- nosy: +loewis ___ Python tracker __

[issue14398] bz2.BZ2DEcompressor.decompress fail on large files

New submission from Laurent Gautier : The call ends with: Objects/stringobject.c:3884: bad argument to internal function sys.version: '2.7.2 (default, Jun 13 2011, 15:14:50) \n[GCC 4.4.5]' (on 64bit Linux) -- messages: 156698 nosy: Laurent.Gautier priority: normal severity: normal statu