[issue14387] Include\accu.h incompatible with Windows.h

Georg Brandl added the comment: I think so, yes. -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue14387] Include\accu.h incompatible with Windows.h

Stefan Krah added the comment: I think the issue is fixed in all affected branches. Georg, can we close it? -- resolution: -> fixed stage: -> committed/rejected status: open -> pending ___ Python tracker ___

[issue14387] Include\accu.h incompatible with Windows.h

Roundup Robot added the comment: New changeset f91ecbc8bafc by Kristján Valur Jónsson in branch '3.2': Issue #14387 : undefine 'small' so that it doesn't clash with Windows headers. http://hg.python.org/cpython/rev/f91ecbc8bafc -- ___ Python tracker

[issue14387] Include\accu.h incompatible with Windows.h

Georg Brandl added the comment: Transplanted to f91ecbc8bafc in 3.2.3 release clone. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue14387] Include\accu.h incompatible with Windows.h

Georg Brandl added the comment: No it won't: but it's harmless enough that I think it can go into the final without creating another rc. -- ___ Python tracker ___ _

[issue14387] Include\accu.h incompatible with Windows.h

Stefan Krah added the comment: > The fix solved my apsw build problem. Thanks for testing. As for the test failure, that could be really anything. Often these kinds of failures turn out to be overly strict assumptions in the test suite. Best ask the maintainer of the package. So 3.3 is cover

[issue14387] Include\accu.h incompatible with Windows.h

.1, '') - [(3.1, 'xabc'), (3.2, 'xabfff"c')] + [(3.1, ''), (3.2, '')] -- Ran 78 tests in 787.594s FAILED (failures=1) - Original Message - From: "Stefan Krah" To: Sent: Monday, April 02, 2012 09:31 Subje

[issue14387] Include\accu.h incompatible with Windows.h

Stefan Krah added the comment: Jeff Robbins wrote: > I'm happy to try another build of apsw, but am not up-to-speed with how to > get development copies of Python. As a user, I typically download the > latest Windows .msi file and install it. If you can point me to a document > on how to p

[issue14387] Include\accu.h incompatible with Windows.h

e it a try. I'm Bcc'ing the APSW author in the event he can give it a try. - Original Message - From: "Stefan Krah" To: Sent: Sunday, April 01, 2012 7:48 AM Subject: [issue14387] Include\accu.h incompatible with Windows.h Stefan Krah added the comment: > Should

[issue14387] Include\accu.h incompatible with Windows.h

Stefan Krah added the comment: > Should I contact the extension's author(s)/maintainer(s) and tell them about > this ordering requirement? FWIW, it is the recommended way in the docs. The Python build itself has been fixed. Does the http://code.google.com/p/apsw/ module build now? ---

[issue14387] Include\accu.h incompatible with Windows.h

Roundup Robot added the comment: New changeset aff7ff2aae8c by Kristján Valur Jónsson in branch '3.2': Issue #14387 : undefine 'small' so that it doesn't clash with Windows headers. http://hg.python.org/cpython/rev/aff7ff2aae8c New changeset 780aaa7b4b62 by Kristján Valur Jónsson in branch 'def

[issue14387] Include\accu.h incompatible with Windows.h

Kristján Valur Jónsson added the comment: Sure, that's simpler. I'll submit a fix. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue14387] Include\accu.h incompatible with Windows.h

Antoine Pitrou added the comment: > Now unicodedata.c does not compile with VS2010, because somewhere, "small" is > defined. > Do you mind if I change the _PyAccu.small member to 'smalls'? How about the #undef suggested somewhere? -- ___ Python tra

[issue14387] Include\accu.h incompatible with Windows.h

Kristján Valur Jónsson added the comment: Now unicodedata.c does not compile with VS2010, because somewhere, "small" is defined. Do you mind if I change the _PyAccu.small member to 'smalls'? -- nosy: +krisvale ___ Python tracker

[issue14387] Include\accu.h incompatible with Windows.h

Jeff Robbins added the comment: Stefan asked 'Did you include Python.h before or after Windows.h? Extensions are supposed to include Python.h before anything else. ' I downloaded http://code.google.com/p/apsw/ to test it out on the latest sqlite release. I followed the build instructions on

[issue14387] Include\accu.h incompatible with Windows.h

Stefan Krah added the comment: To prevent further confusion. :) db154e62ac03 -> OK 5fe7d19ec49a -> failure 5fe7d19ec49a with #undef patch -> OK So I don't know if it is better to revert to db154e62ac03 or to use the #undef patch. Jeff, you originally said: 'An extension which includes bot

[issue14387] Include\accu.h incompatible with Windows.h

Stefan Krah added the comment: Jeff Robbins wrote: > I am sorry if I've caused any confusion. I am building a Python extension > (APSW), and it includes the sqlite "amalgamation" and also includes Python.h. The Python build itself failed here, too, specifically in unicodeobject.c. But I now

[issue14387] Include\accu.h incompatible with Windows.h

Jeff Robbins added the comment: re Stefan Krah's posting: I am sorry if I've caused any confusion. I am building a Python extension (APSW), and it includes the sqlite "amalgamation" and also includes Python.h. Sqlite includes Windows.h. Which then causes the problem when Python.h is inclu

[issue14387] Include\accu.h incompatible with Windows.h

Stefan Krah added the comment: Jeff's #undef suggestion works here (see patch). But I have a question: Where is Windows.h pulled in anyway? A grep only shows signalmodule.c: $ find . -name "\.hg" -prune -o -type f -print0 | xargs -0 grep -n 'Windows\.h' ./Modules/signalmodule.c:9:#include ./D

[issue14387] Include\accu.h incompatible with Windows.h

Jeff Robbins added the comment: The easiest fix would be to rename the "small" field in accu.h (and of course in any file that references that field.) I have no idea who uses this file. Perhaps the 2nd easiest fix would be to put this after the #include of Windows.h #ifdef small #undef small

[issue14387] Include\accu.h incompatible with Windows.h

Antoine Pitrou added the comment: > Hmm, I still get the error in 13cefcbcc7da: Can you try to find a fix? I don't have anything to test here. -- assignee: pitrou -> ___ Python tracker __

[issue14387] Include\accu.h incompatible with Windows.h

Georg Brandl added the comment: We can of course also rename "small". -- ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue14387] Include\accu.h incompatible with Windows.h

Stefan Krah added the comment: Hmm, I still get the error in 13cefcbcc7da: c:\Users\stefan\pydev\cpython\Include\accu.h(21) : error C2059: syntax error : 'type' c:\Users\stefan\pydev\cpython\Include\accu.h(22) : error C2059: syntax error : '}' c:\Users\stefan\

[issue14387] Include\accu.h incompatible with Windows.h

Georg Brandl added the comment: Sounds reasonable to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue14387] Include\accu.h incompatible with Windows.h

Antoine Pitrou added the comment: Fixed according to Amaury's suggestion. Georg, Benjamin, I think this should probably go into the final releases. -- ___ Python tracker ___ ___

[issue14387] Include\accu.h incompatible with Windows.h

Roundup Robot added the comment: New changeset f34ac2e9d5cf by Antoine Pitrou in branch '3.2': Issue #14387: Do not include accu.h from Python.h. http://hg.python.org/cpython/rev/f34ac2e9d5cf New changeset 5fe7d19ec49a by Antoine Pitrou in branch 'default': Issue #14387: Do not include accu.h f

[issue14387] Include\accu.h incompatible with Windows.h

Changes by Antoine Pitrou : -- nosy: +benjamin.peterson, georg.brandl priority: normal -> release blocker versions: +Python 3.3 ___ Python tracker ___ ___

[issue14387] Include\accu.h incompatible with Windows.h

Amaury Forgeot d'Arc added the comment: I suggest to remove accu.h from Python.h: all functions are private anyway, and it's only used by couple of files. -- assignee: -> pitrou nosy: +amaury.forgeotdarc, pitrou ___ Python tracker

[issue14387] Include\accu.h incompatible with Windows.h

New submission from Jeff Robbins : Windows.h includes RpcNdr.h which does this: #define small char accu.h in Python\Include (Python 3.2.3rc2) has this in it: typedef struct { PyObject *large; /* A list of previously accumulated large strings */ PyObject *small; /* Pending small strin