[issue14252] subprocess.Popen.terminate() inconsistent behavior on Windows

Antoine Pitrou added the comment: Ok, I've then fixed the bug in all 3 branches. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue14252] subprocess.Popen.terminate() inconsistent behavior on Windows

Roundup Robot added the comment: New changeset b6ec3b717f7e by Antoine Pitrou in branch '2.7': Issue #14252: Fix subprocess.Popen.terminate() to not raise an error under Windows when the child process has already exited. http://hg.python.org/cpython/rev/b6ec3b717f7e -- ___

[issue14252] subprocess.Popen.terminate() inconsistent behavior on Windows

Roundup Robot added the comment: New changeset 41b1fe5a75a6 by Antoine Pitrou in branch '3.2': Issue #14252: Fix subprocess.Popen.terminate() to not raise an error under Windows when the child process has already exited. http://hg.python.org/cpython/rev/41b1fe5a75a6 New changeset f452d7d5470d

[issue14252] subprocess.Popen.terminate() inconsistent behavior on Windows

Martin v. Löwis added the comment: +1 for backporting to the bug fix releases. -- nosy: +loewis versions: +Python 2.7, Python 3.2 ___ Python tracker ___

[issue14252] subprocess.Popen.terminate() inconsistent behavior on Windows

Gregory P. Smith added the comment: Raising an exception on terminate is a bug. I'd backport this to 2.7 and 3.2. I don't actually have Windows to test on so i'll leave committing that to people who do. -- ___ Python tracker

[issue14252] subprocess.Popen.terminate() inconsistent behavior on Windows

Antoine Pitrou added the comment: Here is a patch for 3.3. I'm not sure it should be backported, as it's a slight change in behaviour. -- keywords: +patch nosy: +brian.curtin, gregory.p.smith, pitrou, tim.golden stage: -> patch review versions: +Python 3.3 -Python 2.6 Added file: http

[issue14252] subprocess.Popen.terminate() inconsistent behavior on Windows

Dave Abrahams added the comment: By the way, the suggested fix would be for terminate() to return a value indicating if the process were already terminated, and not throw an exception in that case. For a user to handle the issue correctly on Windows is rather a nasty project involving a race

[issue14252] subprocess.Popen.terminate() inconsistent behavior on Windows

New submission from Dave Abrahams : Try the following script on posix and Windows. On Posix: launched . . . exiting killed on Windows: launched . . . exiting Traceback (most recent call last): File "sp.py", line 16, in p.terminate() File "c:\Python26\lib\subprocess.py", line 949, in