[issue14203] bytearray_getbuffer: unnecessary code

Roundup Robot added the comment: New changeset e8fe32d43c96 by Stefan Krah in branch 'default': Issue #14203: Remove obsolete support for view==NULL in PyBuffer_FillInfo() https://hg.python.org/cpython/rev/e8fe32d43c96 -- nosy: +python-dev ___ Python

[issue14203] bytearray_getbuffer: unnecessary code

Stefan Krah added the comment: New patch with tests. -- Added file: http://bugs.python.org/file38003/issue14203-2.diff ___ Python tracker ___

[issue14203] bytearray_getbuffer: unnecessary code

Kelley Nielsen added the comment: I have verified that this feature is unused in the source tree; in fact, there are no internal calls to bytearray_getbuffer() at all. The only thing bytearray_getbuffer() does with its second arg is pass it to PyBuffer_FillInfo(), which immediately checks it a

[issue14203] bytearray_getbuffer: unnecessary code

Stefan Krah added the comment: I seems to be a feature to get a "lock" on an exporter without the exporter filling in a buffer. It was there from the beginning: http://svn.python.org/view/python/branches/release30-maint/Objects/bytearrayobject.c?r1=56849&r2=57181 Last use that I can see is he

[issue14203] bytearray_getbuffer: unnecessary code

Stefan Krah added the comment: array_buffer_getbuf does a similar thing: if (view==NULL) goto finish; finish: self->ob_exports++; // ??? return 0 Where does this view==NULL thing come from? -- ___ Python tracker

[issue14203] bytearray_getbuffer: unnecessary code

New submission from Stefan Krah : bytearray_getbuffer() checks for view==NULL. But this has never been allowed: PEP: "The second argument is the address to a bufferinfo structure. Both arguments must never be NULL." DOCS (3.2): "view must point to an existing Py_buffer structure