[issue14158] test_mailbox fails if file or dir named by support.TESTFN exists

2012-03-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1112c2f602b3 by Vinay Sajip in branch '2.7': Closes #14158: We now track test_support.TESTFN cleanup, and test_mailbox uses shutil.rmtree for simpler code. http://hg.python.org/cpython/rev/1112c2f602b3 -- status: pending -> closed ___

[issue14158] test_mailbox fails if file or dir named by support.TESTFN exists

2012-03-02 Thread Vinay Sajip
Vinay Sajip added the comment: > Is 2.7 not affected? It might be, but the code for regrtest looked somewhat different. I will revisit this once the buildbots have run for a few days with the 3.x changes, to confirm that they are OK. Marking as pending to remind me. -- status: closed

[issue14158] test_mailbox fails if file or dir named by support.TESTFN exists

2012-03-01 Thread Éric Araujo
Éric Araujo added the comment: Is 2.7 not affected? -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue14158] test_mailbox fails if file or dir named by support.TESTFN exists

2012-03-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 707586c70195 by Vinay Sajip in branch '3.2': Closes #14158: improved resilience to test files left behind. http://hg.python.org/cpython/rev/707586c70195 New changeset a92e73dfbff6 by Vinay Sajip in branch 'default': Closes #14158: merged test file

[issue14158] test_mailbox fails if file or dir named by support.TESTFN exists

2012-03-01 Thread Vinay Sajip
Vinay Sajip added the comment: Updated patch available on Rietveld - I'll commit it four hours from now if there are no objections. -- ___ Python tracker ___ __

[issue14158] test_mailbox fails if file or dir named by support.TESTFN exists

2012-02-29 Thread Vinay Sajip
Changes by Vinay Sajip : Added file: http://bugs.python.org/file24687/b0da15d31aec.diff ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue14158] test_mailbox fails if file or dir named by support.TESTFN exists

2012-02-29 Thread Vinay Sajip
Changes by Vinay Sajip : -- hgrepos: +115 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue14158] test_mailbox fails if file or dir named by support.TESTFN exists

2012-02-29 Thread Vinay Sajip
Vinay Sajip added the comment: > You should find which test left the file and fix that test instead. Ideally yes, but it's easier said than done. When the failure occurred, there were many failures, and I couldn't locate the place where the file was being left behind. It was a while ago - I w

[issue14158] test_mailbox fails if file or dir named by support.TESTFN exists

2012-02-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: > test_mailbox fails if another failed test leaves a file or directory > with the name given by support.TESTFN. The attached patch rectifies this You should find which test left the file and fix that test instead. -- nosy: +pitrou

[issue14158] test_mailbox fails if file or dir named by support.TESTFN exists

2012-02-29 Thread R. David Murray
R. David Murray added the comment: Why not just call the helper in setUp? Otherwise, it looks good to me. This is a bug fix and should be backported, I believe. -- versions: +Python 2.7, Python 3.2 ___ Python tracker

[issue14158] test_mailbox fails if file or dir named by support.TESTFN exists

2012-02-29 Thread Vinay Sajip
Changes by Vinay Sajip : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue14158] test_mailbox fails if file or dir named by support.TESTFN exists

2012-02-29 Thread Vinay Sajip
New submission from Vinay Sajip : test_mailbox fails if another failed test leaves a file or directory with the name given by support.TESTFN. The attached patch rectifies this, and also uses existing stdlib functionality (shutil.rmtree) to remove a directory tree recursively on tearDown.