[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

Serhiy Storchaka added the comment: Thank you Martin for your review. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

Roundup Robot added the comment: New changeset 929c2d076a85 by Serhiy Storchaka in branch '3.5': Issue #14061: Misc fixes and cleanups in archiving code in shutil. https://hg.python.org/cpython/rev/929c2d076a85 New changeset 268d3763bb07 by Serhiy Storchaka in branch '3.6': Issue #14061: Misc fi

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file45466/shutil_make_archive_misc_3.patch ___ Python tracker ___ ___ Python-

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka versions: +Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mail

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

Changes by Serhiy Storchaka : -- versions: -Python 3.4 Added file: http://bugs.python.org/file43517/shutil_make_archive_misc_2.patch ___ Python tracker ___ _

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

Serhiy Storchaka added the comment: Yes, I were going to left this for other issue, but now I agree that it is better to left zip in unarhiving registry unconditionally. In 2.7 the support of bztar is not conditional. -- ___ Python tracker

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

Martin Panter added the comment: Remember that you probably should not mention “xztar” in the 3.4 or 2.7 docs (even though “lzma” exists in 3.4). I am not too familiar with using shutil or zipfile, but it seems like extraction of some zip files is always possible, even if zlib (for Deflate) i

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

Serhiy Storchaka added the comment: Most of issues are already fixed. Proposed patch fixes remnants: * You see a skip message when bz2 or lzma are not available, instead of silent non-testing. * Removed a code that handles zipfile import failure. Importing zipfile now is always successful. *

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka type: -> behavior versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker ___ _

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

Éric Araujo added the comment: test_shutil contains partial tests for the archiving functionality. I plan to rewrite some tests so that for example you can see a skip message when bz2 is not available, instead of silent non-testing. Also, the internal functions _make_tarfile and _make_zipfi