[issue14050] Tutorial, list.sort() and items comparability

Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue14050] Tutorial, list.sort() and items comparability

Raymond Hettinger added the comment: New changeset cb8de91dadf15925fb95069cb190398e1d485f56 by Raymond Hettinger (Miss Islington (bot)) in branch '3.8': bpo-14050: Note that not all data can be sorted (GH-15381) (GH-15395) https://github.com/python/cpython/commit/cb8de91dadf15925fb95069cb1903

[issue14050] Tutorial, list.sort() and items comparability

Change by miss-islington : -- pull_requests: +15103 pull_request: https://github.com/python/cpython/pull/15395 ___ Python tracker ___ __

[issue14050] Tutorial, list.sort() and items comparability

Raymond Hettinger added the comment: New changeset 4109263a7edce11194e301138cf66fa2d07f7ce4 by Raymond Hettinger in branch 'master': bpo-14050: Note that not all data can be sorted (GH-15381) https://github.com/python/cpython/commit/4109263a7edce11194e301138cf66fa2d07f7ce4 -- _

[issue14050] Tutorial, list.sort() and items comparability

Change by Raymond Hettinger : -- pull_requests: +15091 pull_request: https://github.com/python/cpython/pull/15381 ___ Python tracker ___ ___

[issue14050] Tutorial, list.sort() and items comparability

Martin Panter added the comment: The first paragraph in the patch already seems to have been applied, for Issue 21575. The Sorting How-to already guarantees that defining only __lt__() is sufficient for sorted() and list.sort(). A

[issue14050] Tutorial, list.sort() and items comparability

R. David Murray added the comment: Unless I'm misremembering, it is exactly __lt__ (or __gt__, if __lt__ returns NotImplemented) that sorting depends on. Since I'm sure there is code out there that depends on this fact, I wonder if it should be part of the language definition. Also, the comp

[issue14050] Tutorial, list.sort() and items comparability

Andy Maier added the comment: Comments on v2 of both patches: 1. The paragraph "Each item needs to ..." describes the requirement in terms of "ordering relationships between items". It would be both simpler and less ambiguous to describe the requirement in terms of "type must be orderable". Se

[issue14050] Tutorial, list.sort() and items comparability

Andy Maier added the comment: uploaded patch version py27_v2, which contains the same changes as py34_v2, relative to 2.7, except for this differences: 1. The change from "default" was already in 2.7. 2. The reference to defining ordering methods for user-defined classes includes a reference

[issue14050] Tutorial, list.sort() and items comparability

Andy Maier added the comment: Uploaded patch version py34_v2, which contains the following changes relative to 3.4: 1. The changes in the description of list.sort() from "default" in list.sort(), by adding this text: (the arguments can be used for sort customization, see :func:`sorted` for

[issue14050] Tutorial, list.sort() and items comparability

Changes by Raymond Hettinger : -- assignee: docs@python -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list ma

[issue14050] Tutorial, list.sort() and items comparability

R. David Murray added the comment: The review link will also appear if the patch is generated via hg diff with diff.git turned *off*. You will note that both existing patches use --git, which omits parent changeset information, so our system can't figure out what to apply them against in orde

[issue14050] Tutorial, list.sort() and items comparability

Andy Maier added the comment: Ah! I was somehow suspecting that. Thanks for clarifying! I'll prepare a patch. To correct my earlier message, the best place to link for comparisons is probably the Conparisons subchapter of the Expressions chapter in the reference. See also issue12067. ---

[issue14050] Tutorial, list.sort() and items comparability

Ezio Melotti added the comment: > Why do the patches attached to this issue not have a "review" link? because > both (2.7 and 3.2) patches do not line up with the current > 2.7 and 3.x tip, both hunks get rejected. The "review" link only appears if the patch applies cleanly on the "default" b

[issue14050] Tutorial, list.sort() and items comparability

Andy Maier added the comment: Just out of curiosity: Why do the patches attached to this issue not have a "review" link? Also, both (2.7 and 3.2) patches do not line up with the current 2.7 and 3.x tip, both hunks get rejected. Comments on both patches: 1. It would be helpful if the text "Ea

[issue14050] Tutorial, list.sort() and items comparability

Éric Araujo added the comment: Nope, the expression would be hyphenated only when used as an adjective: - “This sorts the sequence in place” vs. ‑ “Performs an in-place rearrangement by birthdate” -- ___ Python tracker

[issue14050] Tutorial, list.sort() and items comparability

Tshepang Lekhonkhobe added the comment: An an aside, shouldn't that be "in-place" instead of "in place (http://en.wikipedia.org/wiki/In-place)? -- nosy: +tshepang ___ Python tracker __

[issue14050] Tutorial, list.sort() and items comparability

Éric Araujo added the comment: If I had read your patched version when I was a beginner, I don’t think it would have helped me much. (Sorry for not coming up with an alternative right now, it’s late/early here and I’m tired :) -- nosy: +eric.araujo, terry.reedy _

[issue14050] Tutorial, list.sort() and items comparability

Ezio Melotti added the comment: We could just mention that a TypeError is raised if some of the elements can't be compared. (Note that sorting a list that contains some types that cannot be compared might still succeed in some corner cases, but there's no reason to mention this). --

[issue14050] Tutorial, list.sort() and items comparability

Changes by Sandro Tosi : Added file: http://bugs.python.org/file24558/list_sort-py32.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue14050] Tutorial, list.sort() and items comparability

New submission from Sandro Tosi : I'm providing patches for what reported at http://mail.python.org/pipermail/docs/2012-February/007481.html . I'm not sure on wording or even if we want them in the tutorial section, but I think it would be nice to have it documented nonetheless. -- as