[issue13963] dev guide has no mention of mechanics of patch review

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue13963] dev guide has no mention of mechanics of patch review

Martin Panter added the comment: FTR: The Mercurial bug has wandered to . It suggests using “hg --config diff.git=0 diff”. Also, this 2011 post has some details of how the Git patch format is accepted or not (not sure if anything has changed

[issue13963] dev guide has no mention of mechanics of patch review

Ezio Melotti added the comment: Since we are moving away from rietveld, I'm going to close this as out of date. -- resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue13963] dev guide has no mention of mechanics of patch review

Ezio Melotti added the comment: If someone familiar with rietveld wants to propose a patch I will review and apply it, otherwise it might take a while before I can get to it. The patch should include these things: 1) how to make a patch that works with rietveld (this might already be mentioned

[issue13963] dev guide has no mention of mechanics of patch review

Mark Lawrence added the comment: This strikes me as a sizable hole in our documentation. Are there any plans to implement this as I quick glance at the devguide has no references to rietveld that I can find? -- nosy: +BreamoreBoy ___ Python tracker

[issue13963] dev guide has no mention of mechanics of patch review

Changes by Akira Kitada : -- nosy: +akitada ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue13963] dev guide has no mention of mechanics of patch review

Chris Jerdonek added the comment: I created issue 16931 to document a way to use Rietveld for 2.7 patches, while still keeping the Mercurial configuration we advise. -- ___ Python tracker _

[issue13963] dev guide has no mention of mechanics of patch review

Chris Jerdonek added the comment: I asked on the Mercurial tracker about suppressing git-style diffs when git is configured on, and there is a work-around: http://bz.selenic.com/show_bug.cgi?id=3761 We could mention this in the devguide somewhere (e.g. in a FAQ about how to use Rietveld with

[issue13963] dev guide has no mention of mechanics of patch review

Chris Jerdonek added the comment: > If this is true, we could simply add a way to specify the branch (either a > dropdown in the roundup UI or an X.Y in the filename). It would be cool if this could happen even without any user action (e.g. if Rietveld tried default, 3.2, and 2.7 in sequence u

[issue13963] dev guide has no mention of mechanics of patch review

Ezio Melotti added the comment: See also #11869. -- assignee: -> ezio.melotti stage: -> needs patch type: -> enhancement ___ Python tracker ___ ___

[issue13963] dev guide has no mention of mechanics of patch review

Ezio Melotti added the comment: Most of the patches are against 3.2 or 2.7, so applying them to "default" might fail. If we specify the correct branch, rietveld should be able to apply them cleanly to the head of the branch even without knowing the exact revision (so even with git-style diff)

Re: [issue13963] dev guide has no mention of mechanics of patch review

Yeah, the other option is to fix the tracker-reitveld integration. (Which I assumed was harder because diff did not give hg info required for it) ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archi

[issue13963] dev guide has no mention of mechanics of patch review

Éric Araujo added the comment: This is highly debatable. All Mercurial guides that I’ve seen recommend setting git=on because of its many advantages. On the other side there is only one inconvenient. I’m strongly opposed to removing that info from the devguide because one tool can’t cope w

[issue13963] dev guide has no mention of mechanics of patch review

Senthil Kumaran added the comment: It should be noted that diff in git supported format is recommended in the devguide - http://docs.python.org/devguide/committing.html#minimal-configuration If it breaks the rietveld integration, then we should not be advising it. -- nosy: +orsenth

[issue13963] dev guide has no mention of mechanics of patch review

Dave Malcolm added the comment: It would appear that having: [diff] git = on in ~/.hgrc breaks the rietveld integration, since "hg diff" then emits a diff that doesn't identify the hg revision number, and hence the importer can't determine the baseline. -- ___

[issue13963] dev guide has no mention of mechanics of patch review

Changes by Dave Malcolm : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue13963] dev guide has no mention of mechanics of patch review

Dave Malcolm added the comment: Some notes from discussion with MvL at PyCon sprint: The ideal is that: - for any patch attached to an issue: the patch is uploaded to a Rietveld instance colocated in the same db as Roundup (bugs.python.org) - if it works, than a "review" link is visible

[issue13963] dev guide has no mention of mechanics of patch review

Nadeem Vawda added the comment: AFAIK, all interested parties are supposed to automatically be sent email notifications whenever anyone posts an update on the review. However, I've run into a bug that seems to be preventing this from workin

[issue13963] dev guide has no mention of mechanics of patch review

Terry J. Reedy added the comment: At one time, reviews (or the fact of a review) were posted back here automatically (or perhaps it is an option?) just like push messages. But I am not much familiar with the process either. -- nosy: +terry.reedy __

[issue13963] dev guide has no mention of mechanics of patch review

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue13963] dev guide has no mention of mechanics of patch review

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue13963] dev guide has no mention of mechanics of patch review

Changes by Nadeem Vawda : -- nosy: +nadeem.vawda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue13963] dev guide has no mention of mechanics of patch review

New submission from Dave Malcolm : I've been waiting for patch review of my work on http://bugs.python.org/issue13703 only to discover that people *have* been reviewing it. It turns out that next to some of the patches in the issue tracker there's a "review" link, which takes me to http://bug