[issue13806] Audioop decompression frames size check fix

2012-02-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: The fix I committed seems ok. Unfortunately the buildbot doesn't compile 3.2 or 3.3, see #13843. -- status: open -> closed ___ Python tracker

[issue13806] Audioop decompression frames size check fix

2012-02-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: Will wait for the buildbot to clear. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue13806] Audioop decompression frames size check fix

2012-02-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset cfbd800af3a4 by Antoine Pitrou in branch '3.2': Fix failing test on big-endian machines (issue #13806). http://hg.python.org/cpython/rev/cfbd800af3a4 New changeset 05b40b006565 by Antoine Pitrou in branch 'default': Fix failing test on big-endian m

[issue13806] Audioop decompression frames size check fix

2012-02-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset bc6e768de2cc by Antoine Pitrou in branch '2.7': Fix failing test on big-endian machines (issue #13806). http://hg.python.org/cpython/rev/bc6e768de2cc -- ___ Python tracker

[issue13806] Audioop decompression frames size check fix

2012-02-04 Thread Charles-François Natali
Charles-François Natali added the comment: This broke a sparc buildbot: """ == FAIL: test_alaw2lin (test.test_audioop.TestAudioop) -- Traceback (most recent ca

[issue13806] Audioop decompression frames size check fix

2012-01-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thank you for your work Oleg! The patch is now committed. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker

[issue13806] Audioop decompression frames size check fix

2012-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 77188bc37c74 by Antoine Pitrou in branch '3.2': Issue #13806: The size check in audioop decompression functions was too strict and could reject valid compressed data. http://hg.python.org/cpython/rev/77188bc37c74 New changeset ce89dcba008f by Anto

[issue13806] Audioop decompression frames size check fix

2012-01-27 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Yes, that tests really should be there too. Added them to patch. -- Added file: http://bugs.python.org/file24344/audioop_size_check.patch ___ Python tracker

[issue13806] Audioop decompression frames size check fix

2012-01-27 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24285/audioop_size_check.patch ___ Python tracker ___ ___ Python-bugs-l

[issue13806] Audioop decompression frames size check fix

2012-01-20 Thread Antoine Pitrou
Antoine Pitrou added the comment: Do you think it would be possible to add a test for valid compressed data that used to trigger the check? -- ___ Python tracker ___ __

[issue13806] Audioop decompression frames size check fix

2012-01-19 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file24285/audioop_size_check.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue13806] Audioop decompression frames size check fix

2012-01-19 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24284/audioop_size_check.patch ___ Python tracker ___ ___ Python-bugs-l

[issue13806] Audioop decompression frames size check fix

2012-01-19 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Yep, you're right. Didn't noticed audioop_check_size() function at first. The fact that audioop accepts unicode strings seems weird to me too. I've replaced strings with bytes in tests. However, I'm afraid to add restrictions to library itself because of ba

[issue13806] Audioop decompression frames size check fix

2012-01-19 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24260/audioop_size_check.patch ___ Python tracker ___ ___ Python-bugs-l

[issue13806] Audioop decompression frames size check fix

2012-01-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: Well, you should just replace these calls with audioop_check_size() instead. Apparently the checks were blindly added in issue7673. By the way, I'm surprised audioop accepts unicode strings... :/ -- nosy: +haypo, pitrou versions: +Python 2.7

[issue13806] Audioop decompression frames size check fix

2012-01-17 Thread Oleg Plakhotnyuk
New submission from Oleg Plakhotnyuk : According to documentation (http://docs.python.org/library/audioop.html), adpcm2lin, alaw2lin and ulaw2lin are using 'width' argument to represent output frames width. However, in audioop.c module there are checks that are raising exceptions if input fram