[issue13706] non-ascii fill characters no longer work in numeric formatting

Martin v. Löwis added the comment: Removing the if condition would be incorrect. The maximum char is computed at the beginning of the formatting. If, during formatting, need for a padding character is determined, the padding character must not be larger than the maximum char of the target str

[issue13706] non-ascii fill characters no longer work in numeric formatting

STINNER Victor added the comment: > I assume this is left over from the PEP 393 changes. Correct. > I'm not sure such a restriction needs to exist any more. The restriction was introduced to simplify the implementation. maxchar has to be computed exactly in format_string_internal(), format_i

[issue13706] non-ascii fill characters no longer work in numeric formatting

Eric V. Smith added the comment: I assume this is left over from the PEP 393 changes. I think the right thing to do is delete this code from line 277 of formatter_unicode.c: if (format->fill_char > 127 || format->align > 127 || format->sign > 127) { PyErr_SetString(PyExc_Va

[issue13706] non-ascii fill characters no longer work in numeric formatting

Changes by Stefan Krah : -- title: Unicode fill characters no longer work in numeric formatting -> non-ascii fill characters no longer work in numeric formatting ___ Python tracker