[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Robert Schuppenies <[EMAIL PROTECTED]> added the comment: Fixed in r65971. Backported to the release25-maint and merged into the py3k branch. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]>

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: I think the new patch looks fine and should be applied. -- nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]> _

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Changes by Guilherme Polo <[EMAIL PROTECTED]>: -- keywords: +needs review -patch ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Pytho

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Robert Schuppenies <[EMAIL PROTECTED]> added the comment: I am sry that you see it that way, I do not. I was given commit access solely for gsoc purposes and committing changes before a late release without review from a committer IMHO violates strict policies. I tried to get somebody to review t

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Guilherme Polo <[EMAIL PROTECTED]> added the comment: Well, beta3 was released and the problem remained there. Robert, I believe MvL assigned this to you for a reason.. I'm a bit stressed but what I'm trying to say is that you could have decided about this issue yourself and you decided to keep

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Guilherme Polo <[EMAIL PROTECTED]> added the comment: If this needs approval of someone else, and such thing doesn't happen in time then the earlier patch should be reverted. ___ Python tracker <[EMAIL PROTECTED]>

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Robert Schuppenies <[EMAIL PROTECTED]> added the comment: I was thinking about returning in that new if statement, too, but decided not too. The reason is that I didn't want to anticipate _tkinter implementations, which may change (although not likely, still possible). Also, with the third beta

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Guilherme Polo <[EMAIL PROTECTED]> added the comment: change this: "You could return if in that new if statement." to: "You could return in that new if statement.", please. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Guilherme Polo <[EMAIL PROTECTED]> added the comment: You could return if in that new if statement. As you noted, the None argument is ignored there, that is because _tkinter checks for a None parameter, and if it happens to be a None, it then stops processing new arguments, so this is not direc

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Robert Schuppenies <[EMAIL PROTECTED]> added the comment: You are right. How about the attached patch, do you see any problems here? Tkinter seems to ignore any delete calls when either of the indices is None, so the deletion of commands may be ignored as well. But I couldn't find a description m

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Guilherme Polo <[EMAIL PROTECTED]> added the comment: Uhm, this patch can cause trouble if not adapted a bit. The index method may return None for either index1 or index2, which will cause a TypeError in that for loop. If code is needed to confirm this, try the following: menu = Tkinter.Menu(tea

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Robert Schuppenies <[EMAIL PROTECTED]> added the comment: Fixed in r65622. Backported to the release25-maint and merged into the py3k branch. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]>

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: The patch is fine, please apply (also to the 2.5 and 3.0 branches). Don't forget a Misc/NEWS entry. -- assignee: loewis -> schuppenies resolution: -> accepted ___ Python tracker <[EMAIL PROTECTED

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

Robert Schuppenies <[EMAIL PROTECTED]> added the comment: The problem does still exist (Python 2.6b2). I attached a patch for Tkinter.py which addresses this problem. It is the same as in the first proposed fix, but adds an additional check whether the menu item has a 'command' property. I also