[issue1327971] HTTPResponse instance has no attribute 'fileno'

Senthil Kumaran added the comment: Documented it in r84933, r84934 and r84935 -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Senthil Kumaran added the comment: Fix committed in revision 84932. A property based fileno was not required, because it is hardly set, it is always often a read-only attribute. Also, py3k behavior is same as the current fix. -- ___ Python tracker

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Changes by Senthil Kumaran : -- assignee: -> orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Changes by Mark Lawrence : -- versions: +Python 2.7 -Python 2.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Changes by Kevin Dwyer : -- nosy: +kevindication ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Mark Lawrence added the comment: These patches are small and marked as easy, can they be accepted? -- nosy: +BreamoreBoy ___ Python tracker ___ ___

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Changes by Daniel Diniz : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Changes by Daniel Diniz : -- nosy: +jjlee ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Changes by Daniel Diniz : -- nosy: +orsenthil versions: -Python 2.4, Python 2.5, Python 2.7 ___ Python tracker ___ ___ Python-bugs-

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Daniel Diniz added the comment: The urllib patch breaks test_pyclbr because test_pyclbr can't handle properties. I think the test is wrong here, hence the hack attached... otherwise, let's go with httplib. Added file: http://bugs.python.org/file13036/test_pyclbr_property.diff _

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Changes by Daniel Diniz : Removed file: http://bugs.python.org/file13031/urllib_fileno.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Changes by Daniel Diniz : Added file: http://bugs.python.org/file13033/urllib_fileno_2.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Changes by Daniel Diniz : Removed file: http://bugs.python.org/file13030/httplib_fileno.diff ___ Python tracker ___ ___ Python-bugs-list mai

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Daniel Diniz added the comment: Hmm, always run all the tests :) fileno is set in test_urllib2. New patches. Added file: http://bugs.python.org/file13032/httplib_fileno_2.diff ___ Python tracker ___

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Changes by Daniel Diniz : -- components: +Library (Lib) -None type: -> behavior Added file: http://bugs.python.org/file13031/urllib_fileno.diff ___ Python tracker ___

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Daniel Diniz added the comment: IMHO, using a fileno property looks better than __getattr__. Setting an attribute in init works too, unless fp changes during the object life (then 3.x is broken IIUC). It works OK as a property of either urllib.addinfourl or of httplib.HTTPResponse (socket would

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Daniel Diniz added the comment: OK, I'll work on a test + patch. ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Brett Cannon added the comment: Another option is to change urllib.addinfourl to look for fileno() on an HTTPResponse object. ___ Python tracker ___ ___

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Brett Cannon added the comment: Georg is right and this has been fixed apparently in 3.0, leaving 2.7 and older broken. There are two possible solutions to this. One is to change socket._fileobject.fileno() to simply try self._sock.fp.fileno() if self._sock.fileno() does not exist. The other op

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Georg Brandl added the comment: Well, easy access is not the point. If the object is supposed to have the file-like interface, and can provide a fileno(), it should. -- nosy: +georg.brandl ___ Python tracker ___

[issue1327971] HTTPResponse instance has no attribute 'fileno'

Daniel Diniz added the comment: Besides being outdated, the OP shows it's trivial to access the fileno: "r.fileno = r.fp.fileno". I suggest closing. -- nosy: +ajaksu2 ___ Python tracker _