[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Roundup Robot added the comment: New changeset edcdef70c44e by Éric Araujo in branch '3.2': Fix long-standing bugs with MANIFEST.in parsing on Windows (#6884). http://hg.python.org/cpython/rev/edcdef70c44e -- ___ Python tracker

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Roundup Robot added the comment: New changeset 4d6a9f287543 by Éric Araujo in branch 'default': Fix bugs with MANIFEST.in parsing on Windows (#6884). http://hg.python.org/distutils2/rev/4d6a9f287543 -- ___ Python tracker

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Roundup Robot added the comment: New changeset 73aa4c9305b3 by Éric Araujo in branch '3.2': Fix long-standing bugs with MANIFEST.in parsing on Windows (#6884). http://hg.python.org/cpython/rev/73aa4c9305b3 -- ___ Python tracker

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Roundup Robot added the comment: New changeset 47788c90f80b by Éric Araujo in branch '2.7': Fix long-standing bugs with MANIFEST.in parsing on Windows (#6884). http://hg.python.org/cpython/rev/47788c90f80b -- ___ Python tracker

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Éric Araujo added the comment: FYI, the last commit was actually incorrect. I must confess that I wanted to fix the buildbots as quick as possible, especially in light of the upcoming-though-undated 2.7 release, and did not read the code as carefully as I should have, but now I have done it

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Éric Araujo added the comment: Sorry I was unavailable. I read and approved of the patch but could not push, so thanks for doing it :) -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Roundup Robot added the comment: New changeset 3925081a7ca0 by Nadeem Vawda in branch '2.7': Issue #13193: Fix distutils.filelist tests to always use / as path separator. http://hg.python.org/cpython/rev/3925081a7ca0 -- ___ Python tracker

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Benjamin Peterson added the comment: Apply! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Nadeem Vawda added the comment: It appears that while test_process_template() uses "/"-delimited paths consistently across all OSes, 2.7 also has a test_process_template_line() that uses os.path.join() to construct its paths. Changing this test to use hardcoded "/"-delimited paths fixes the fail

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Antoine Pitrou added the comment: > I’d say there is a bug in the tests then. Remember that they were > added recently and only tested on posix, so they’re not authoritative. How about people who have similar "bugs" in their code then? I think you're trying to be pure instead of practical. --

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Éric Araujo added the comment: I’d say there is a bug in the tests then. Remember that they were added recently and only tested on posix, so they’re not authoritative. -- ___ Python tracker _

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Antoine Pitrou added the comment: > Possible ways forward: > - One of you gentlemen with a Windows box and a clear head can try to > find a correct fix for the bug This error shows that distutils's own test suite relies on being able to put both kind of path separators in a manifest, so my fix

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Éric Araujo added the comment: Buildbots exist to crush joy: http://www.python.org/dev/buildbot/all/builders/x86%20XP-4%202.7/builds/1285/steps/test/logs/stdio/text Possible ways forward: - One of you gentlemen with a Windows box and a clear head can try to find a correct fix for the bug - If

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Éric Araujo added the comment: Reverted the liberal fix and replaced it with Vinay’s in time for the next bugfix releases. Will watch buildbot and close the report. Thanks to all who helped. -- resolution: -> fixed stage: -> committed/rejected

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Roundup Robot added the comment: New changeset 90b30d62caf2 by Éric Araujo in branch '3.2': Fix distutils.filelist.FileList under Windows (#13193). http://hg.python.org/cpython/rev/90b30d62caf2 New changeset 68347f8430ec by Éric Araujo in branch 'default': Merge fixes for #13193 and FAQ from 3.

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Roundup Robot added the comment: New changeset c566a3447ba1 by Éric Araujo in branch '2.7': Fix distutils.filelist.FileList under Windows (#13193). http://hg.python.org/cpython/rev/c566a3447ba1 -- ___ Python tracker

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Nadeem Vawda added the comment: All tests pass with the patch applied, on both Windows 7 and Ubuntu 11.10. I notice that the patch only changes Lib/packaging/manifest.py; does Lib/distutils/filelist.py perhaps also need to be updated? Changeset 64485e0700ba modified both of these files. --

[issue13193] packaging.tests.test_manifest and distutils.tests.test_filelist failures

Éric Araujo added the comment: Attached is Vinay’s fix as a diff. Can someone test this patch on Windows or any of the other OSes that showed failures? -- keywords: +patch title: test_packaging and test_distutils failures -> packaging.tests.test_manifest and distutils.tests.test_file