[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Roundup Robot added the comment: New changeset 556a11c11edd by Jason R. Coombs in branch '3.4': Issue #27960: Revert state to 675e20c38fdac6, backing out all changes by developed for Issue #12885. https://hg.python.org/cpython/rev/556a11c11edd -- ___

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Changes by Jason R. Coombs : -- versions: -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Roundup Robot added the comment: New changeset e82b995d1a5c by Jason R. Coombs in branch '3.4': Issue #12885: Revert commits in 3.4 branch which is security-only fixes. https://hg.python.org/cpython/rev/e82b995d1a5c New changeset a7ce98a4e9e4 by Jason R. Coombs in branch '3.5': Issue #12885: Mer

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Roundup Robot added the comment: New changeset 590d0de4ff48 by Jason R. Coombs in branch '3.4': Issue #12885: Correct issue reference in NEWS https://hg.python.org/cpython/rev/590d0de4ff48 New changeset 74ccec0bd442 by Jason R. Coombs in branch '3.5': Issue #12885: Merge 3.4 https://hg.python.or

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Martin Panter added the comment: I think you mixed up the bug number. You should probably fix Misc/NEWS. New changeset 941346104718 by Jason R. Coombs in branch '3.4': Issue #12285: Add test capturing failure. https://hg.python.org/cpython/rev/941346104718 New changeset 56c60b3d06fb by Jason R.

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Jason R. Coombs added the comment: This code has been stable in Setuptools for some time, so I've pushed the code into the base. -- resolution: -> fixed status: open -> closed versions: -Python 2.7 ___ Python tracker

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Roundup Robot added the comment: New changeset 79422fab2ef4 by Jason R. Coombs in branch 'default': Issue #12885: Merge with 3.5 https://hg.python.org/cpython/rev/79422fab2ef4 -- nosy: +python-dev ___ Python tracker

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Jason R. Coombs added the comment: > Does the patch change the behaviour for the handling of the MANIFEST file > (not MANIFEST.in)? My previous message mentions that the docs say that one > can include symlinks in MANIFEST. This change will not affect the content of MANIFEST.in (template) nor

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Jason R. Coombs added the comment: After porting the latest released Setuptools version, I discovered yet another regression in the Setuptools implementation, specifically around its handling for this issue, so I've created yet another release of Setuptools (18.3.2) to include tests and fixes

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Changes by Jason R. Coombs : Added file: http://bugs.python.org/file40516/3da42b593e1f.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Jason R. Coombs added the comment: Although the code was ported from setuptools, it wasn't ported from the long stable implementation, but was ported following the recent refactor, which had a [regression](https://bitbucket.org/pypa/setuptools/issues/425/odd-failure-on-183-missing-files-but-th

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Éric Araujo added the comment: Patch looks good and would fix the reported problem. Being a backport from setuptools also gives confidence. Does the patch change the behaviour for the handling of the MANIFEST file (not MANIFEST.in)? My previous message mentions that the docs say that one can

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Changes by Jason R. Coombs : -- keywords: +patch Added file: http://bugs.python.org/file40303/faf37fc3b097.diff ___ Python tracker ___ ___

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Changes by Jason R. Coombs : -- assignee: -> jason.coombs hgrepos: +315 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Jason R. Coombs added the comment: This issue has been monkeypatched by setuptools for 7 years: https://bitbucket.org/pypa/setuptools/commits/4556f9d08ef7 -- assignee: tarek -> components: -Distutils2 nosy: +dstufft, jason.coombs versions: +Python 3.4, Python 3.5 -3rd party, Python 3.

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Éric Araujo added the comment: > I've come across it as I'm creating a Debian package of the Python > package in the same tree I think a lot of people are doing this. > The broken symlinks are relative and in debian/tmp, and will point to > locations provided by other Debian packages once my p

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Alexander Dutton added the comment: I've come across it as I'm creating a Debian package of the Python package in the same tree — I'm happy to be told this is a Bad Idea and that they should be in different places. The broken symlinks are relative and in debian/tmp, and will point to location

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

Éric Araujo added the comment: Symlinks are barely supported by distutils; the only mention you can find in the doc is that the MANIFEST file can contain symlinks. In the light of that, one could argue that broken symlinks are not supported nor ignored, and that you just should not have them

[issue12885] distutils.filelist.findall() fails on broken symlink in Py2.x

New submission from Alexander Dutton : If there are any broken symlinks in the same directory as a setup.py when e.g. sdist is run, findall() will fall over when attempting to os.stat() the symlink: Traceback (most recent call last): File "setup.py", line 81, in run _sdist.run(self) Fil