[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Jelle Zijlstra added the comment: Mike's fix unfortunately didn't work out. What are the rules about closing old enhancement requests? modulefinder is an old and rarely used package, and I feel like the use case is better served by a PyPI package. -- nosy: +Jelle Zijlstra _

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Change by mike mcleod : -- pull_requests: +28450 pull_request: https://github.com/python/cpython/pull/30228 ___ Python tracker ___ ___

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

mike mcleod added the comment: Minor fix after test. -- Added file: https://bugs.python.org/file50467/2.html ___ Python tracker ___ _

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

mike mcleod added the comment: I have made the changes as indicated in the diff files. I have tested against the latest from my GitHub copy. The result is: ./python -m test -j0 == CPython 3.11.0a2+ (heads/main:3a91617590, Dec 1 2021, 15:11:41) [GCC 11.2.0] == Linux-5.13.0-22-generic-x86_64-with

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

mike mcleod added the comment: Ok, I will work on this soon and make further comments. -- ___ Python tracker ___ ___ Python-bugs-

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Irit Katriel added the comment: Mike, from looking at the code the change proposed here is not there, so while the patch may not apply cleanly anymore, the commits you mention do not make this issue irrelevant. -- nosy: +iritkatriel ___ Python tra

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Change by Ethan Furman : -- nosy: +ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

mike mcleod added the comment: I would like to help with this issue. I note the history (using Git Dag) of the modulefinder.py shows that it has been modified with changes related here: Author: Éric Araujo 2011-07-28 22:35:29 Committer: Éric Araujo 2011-07-28 22:35:29 Parent: 867754e3e3c9

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Changes by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Éric Araujo added the comment: I modernized modulefinder a bit in 1521d9837d16; here’s a refreshed patch. -- Added file: http://bugs.python.org/file22792/modulefinder-no-recurse.diff ___ Python tracker _

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Changes by Éric Araujo : Removed file: http://bugs.python.org/file22686/modulefinder-no-recurse.diff ___ Python tracker ___ ___ Python-bugs-

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Changes by Eric Snow : -- nosy: +ericsnow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Éric Araujo added the comment: I applied the patch, added a test and found a bug. Here’s my progress so far; someone can start from it to write more tests and fix the code. -- nosy: +misc Added file: http://bugs.python.org/file22686/modulefinder-no-recurse.diff __

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Éric Araujo added the comment: The depth parameter idea sounds like YAGNI, so let’s stay with a recurse boolean :) -- assignee: -> eric.araujo nosy: -BreamoreBoy, misc_from_metz stage: unit test needed -> patch review versions: +Python 3.3 -Python 3.2 ___

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Nick Coghlan added the comment: Although I do find it a little concerning that there is no mention of sys.path_hooks or sys.meta_path in the modulefinder source code. I suspect this module only works correctly with vanilla filesystem based imports and can't handle anything imported via PEP 30

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Nick Coghlan added the comment: The generalist in me is inclined to suggest a "depth" parameter (with depth=1 equivalent to direct dependencies only, and depth = None meaning all dependencies), but I must admit I don't have a concrete use case for the extra generality. So the simpler, recurse

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Éric Araujo added the comment: Adding jvr and people interested in import machinery, per Misc/maintainers.rst Michael, can you refresh your patch against the py3k branch? Please also generate a unified diff from the top level of the source distribution, as detailed in http://www.python.org/de

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Mark Lawrence added the comment: Anyone interested in this or can it be closed? -- nosy: +BreamoreBoy versions: +Python 3.2 -Python 2.7 ___ Python tracker ___

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Changes by Daniel Diniz : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

Changes by Daniel Diniz : -- stage: -> test needed type: -> feature request versions: +Python 2.7 ___ Python tracker ___ ___ Pytho