[issue12605] Enhancements to gdb 7 debugging hooks

Changes by Antoine Pitrou : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue12605] Enhancements to gdb 7 debugging hooks

Antoine Pitrou added the comment: Dave, test_gdb fails consistently on the ARM buildbot: == FAIL: test_threads (test.test_gdb.PyBtTests) Verify that "py-bt" indicates threads that are waiting for the GIL --

[issue12605] Enhancements to gdb 7 debugging hooks

Changes by Antoine Pitrou : -- priority: release blocker -> normal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue12605] Enhancements to gdb 7 debugging hooks

Roundup Robot added the comment: New changeset abcd29c9a791 by David Malcolm in branch 'default': Issue #12605: Show information on more C frames within gdb backtraces http://hg.python.org/cpython/rev/abcd29c9a791 -- nosy: +python-dev ___ Python trac

[issue12605] Enhancements to gdb 7 debugging hooks

Dave Malcolm added the comment: I believe this was due to this line: return self._gdbframe.name().startswith('pthread_cond_timedwait') within is_waiting_for_gil(), and your gdb returned None for self._gdbframe.name() for your build. I've changed it to: name = self._gdbframe.name() if na

[issue12605] Enhancements to gdb 7 debugging hooks

Antoine Pitrou added the comment: Got the following error on Mageia 1: == FAIL: test_threads (test.test_gdb.PyBtTests) Verify that "py-bt" indicates threads that are waiting for the GIL -

[issue12605] Enhancements to gdb 7 debugging hooks

Georg Brandl added the comment: Agreed with Martin, can't say I'm +1 on 3.3 either. But I've just reviewed the patch, and it looks correct to me, so go ahead and I'll take the blame. -- ___ Python tracker __

[issue12605] Enhancements to gdb 7 debugging hooks

Martin v. Löwis added the comment: I'm +1 on adding this in general, +0 on adding this to 3.3, and -0 on adding it to 2.7 right away. I agree that the usual reasoning against new features doesn't apply here, since it's not a new Python (language or library) feature. However, one concern is t

[issue12605] Enhancements to gdb 7 debugging hooks

Gregory P. Smith added the comment: Better debuggability FTW! This is an update to Tools/gdb/ as such I'd like to see this make it into 3.3. It doesn't touch the runtime or stdlib so I personally wouldn't consider this "adding a feature" and thus preventing its inclusion with 3.3 despite the

[issue12605] Enhancements to gdb 7 debugging hooks

Antoine Pitrou added the comment: The improvements are welcome, but I'm not sure they're ok for 3.2 or 2.7, since they're technically a new feature. OTOH, one could argue that better debuggability trumps the no-feature rule. -- nosy: +pitrou stage: -> patch review ___

[issue12605] Enhancements to gdb 7 debugging hooks

Changes by Georg Brandl : -- nosy: +georg.brandl, loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue12605] Enhancements to gdb 7 debugging hooks

Dave Malcolm added the comment: (On 2.7, I needed import_site=True to get the new tests to work from a fresh build: "import time" wasn't being found otherwise) -- Added file: http://bugs.python.org/file22713/more-frames-in-gdb-hooks-2.7.patch ___ Py

[issue12605] Enhancements to gdb 7 debugging hooks

Changes by Dave Malcolm : -- keywords: +patch Added file: http://bugs.python.org/file22712/more-frames-in-gdb-hooks-py3k.patch ___ Python tracker ___

[issue12605] Enhancements to gdb 7 debugging hooks

New submission from Dave Malcolm : I'm attaching patches to handle some more "events" in the gdb7 debugging hooks for CPython (aka Tools/gdb/libpython.py). Currently, the hooks only care about C frames that are the bytecode interpreter (i.e. PyEval_EvalFrameEx) This patch changes this, dividi