[issue12536] lib2to3 BaseFix class creates un-needed loggers leading to refleaks

Roundup Robot added the comment: New changeset dd004e85e299 by Vinay Sajip in branch 'default': Closes #12536: Unused logger removed from lib2to3. http://hg.python.org/cpython/rev/dd004e85e299 -- nosy: +python-dev resolution: -> fixed stage: -> committed/rejected status: open -> close

[issue12536] lib2to3 BaseFix class creates un-needed loggers leading to refleaks

Benjamin Peterson added the comment: I say kill the loggers. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12536] lib2to3 BaseFix class creates un-needed loggers leading to refleaks

Éric Araujo added the comment: If the logger attribute is part of the official API and Benjamin doesn’t think it wise to just remove it, I think we should either start deprecating it (using a property), or set it to a shared logger object instead of creating one per file. -- ___

[issue12536] lib2to3 BaseFix class creates un-needed loggers leading to refleaks

New submission from Vinay Sajip : See #12167 for background. The BaseFix class creates a logger named with the filename when the set_filename method is called. This logger appears to never be used, but since set_filename could be called any number of times and loggers are effectively singleto