[issue12424] distutils2: extension section uses bad environment marker separator

Changes by Éric Araujo : -- resolution: -> out of date stage: -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue12424] distutils2: extension section uses bad environment marker separator

Éric Araujo added the comment: Latest patch looks good. Looking at the examples with ';;' or even '--', I think that their role is non-obvious. Even though the PEP and docs explained them, there is value in using intuitive (“guessable”) markup. So if the constraints are that a marker delim

[issue12424] distutils2: extension section uses bad environment marker separator

Éric Araujo added the comment: > if a line ends with ";;", _pop_values() will call interpret() with an empty > string. [...] > it just means interpret() would return False, causing the line to be ignored, > which is probably > fine for that border case Hm, I’d rather call that a bug. _pop_va

[issue12424] distutils2: extension section uses bad environment marker separator

Eli Collins added the comment: The second patchset (9170231ebf14.diff) should implement all the changes you suggested in your second review (dated 2011-09-05). --- The only non-addressed item in your second review was a request for clarification on a potential error I noticed (and described

[issue12424] distutils2: extension section uses bad environment marker separator

Éric Araujo added the comment: Does your latest patch address my second review? -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue12424] distutils2: extension section uses bad environment marker separator

Eli Collins added the comment: I've attached a second revision of my patch to fix this issue (9170231ebf14.diff). Per Eric Araujo's advice, this patch changes _pop_values() to use ";;" as the environment marker separator for all fields in setupcfg's extension sections. I've also updated the

[issue12424] distutils2: extension section uses bad environment marker separator

Changes by Eli Collins : -- hgrepos: +70 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue12424] distutils2: extension section uses bad environment marker separator

Changes by Eli Collins : Added file: http://bugs.python.org/file23247/9170231ebf14.diff ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue12424] distutils2: extension section uses bad environment marker separator

Changes by Eli Collins : -- keywords: +patch Added file: http://bugs.python.org/file22503/cpython_issue12424.patch ___ Python tracker ___

[issue12424] distutils2: extension section uses bad environment marker separator

New submission from Eli Collins : The _pop_values() function in packaging.config uses "--" as the environment marker separator when parsing extension sections. This doesn't match PEP 345, or how the metadata section is currently parsed, both of which use ";" instead. Also, "--" is frequently f