[issue12386] packaging fails in install_distinfo when writing RESOURCES

Roundup Robot added the comment: New changeset cb49bc384957 by Éric Araujo in branch 'default': Fix writing of the RESOURCES file (#12386). http://hg.python.org/distutils2/rev/cb49bc384957 New changeset 2d469ccfe30e by Éric Araujo in branch 'python3': Merge fixes for #13170 and #12386 and other

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Éric Araujo added the comment: I’ve reproduced the bug and fixed it by opening in text mode, following all other calls to open in the same file. This should now work for ASCII paths and non-ASCII paths that use the same encoding as open’s default, but it’ll probably break with non-ASCII path

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Roundup Robot added the comment: New changeset 1f3459b08298 by Éric Araujo in branch 'default': Fix writing of the RESOURCES file by packaging (#12386) http://hg.python.org/cpython/rev/1f3459b08298 -- nosy: +python-dev ___ Python tracker

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Éric Araujo added the comment: I have a test. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Éric Araujo added the comment: I started to look at this a few days ago and found out that there are no tests at all for writing RESOURCES. I need to look again at the documentation and code and add many tests. -- ___ Python tracker

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Vinay Sajip added the comment: I got the problem when installing a package with resources using pysetup3. Here's the relevant part of the console session: (venv) vinay@eta-natty:~/projects$ pysetup3 install nemo Installing from source directory: /home/vinay/projects/nemo running install_dist r

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Éric Araujo added the comment: I’d like to fix this. How can I reproduce the bug? -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Vinay Sajip added the comment: I looked at this bug again - I was getting a little confused about it ;-) The problem is happening not when writing out a resource, but the RESOURCES file listing the resources installed. This is a text file, of course, so my suggested fix of using open(resource

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Éric Araujo added the comment: > I also noticed that your latest comment > "All text is bytes, so we can do all I/O in bytes when writing > resources and avoid special-casing." > contradicts your earlier position: > "I agree about the nonsense of opening in binary mode." It does :) My earlier

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Vinay Sajip added the comment: @Éric: I also noticed that your latest comment "All text is bytes, so we can do all I/O in bytes when writing resources and avoid special-casing." contradicts your earlier position: "I agree about the nonsense of opening in binary mode." If using text mode, w

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Vinay Sajip added the comment: > I don’t see why. All text is bytes, so we can do all I/O in bytes > when writing resources and avoid special-casing. I was only commenting on how the bug might have come about. > A link to a specific changeset or file would be great. https://bitbucket.org/vin

[issue12386] packaging fails in install_distinfo when writing RESOURCES

trevor added the comment: [eric.araujo] > Do you see that when running a test, a command or some other code? when attempting to install a self-created package. tools from 3.3a ~72060:1696e2789d91 -- ___ Python tracker

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Éric Araujo added the comment: > I only meant that when writing data resources, one might reasonably > use 'wb', but when writing scripts, which are text, 'w' is more > appropriate. I don’t see why. All text is bytes, so we can do all I/O in bytes when writing resources and avoid special-casi

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Vinay Sajip added the comment: BTW, IIRC I have fixed it in the pythonv branch. https://bitbucket.org/vinay.sajip/pythonv -- ___ Python tracker ___

[issue12386] packaging fails in install_distinfo when writing RESOURCES

trevor added the comment: i see the same behavior - the error occurs leaving an empty RESOURCES file -- ___ Python tracker ___ ___ Py

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Vinay Sajip added the comment: Éric: I only meant that when writing data resources, one might reasonably use 'wb', but when writing scripts, which are text, 'w' is more appropriate. -- ___ Python tracker

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Éric Araujo added the comment: Vinay: I don’t understand your message. I wasn’t part of the effort that added the resources subsystem, so I will work on a patch for this bug to learn more about it. -- ___ Python tracker

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Changes by trevor : -- nosy: +trevor ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mai

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Vinay Sajip added the comment: I suppose it's because I'm writing a script as if it were data? (i.e. to the {scripts} location. -- ___ Python tracker ___ __

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Éric Araujo added the comment: It is strange that neither the tests for install_distinfo and resources did not catch this. I agree about the nonsense of opening in binary mode. -- assignee: tarek -> eric.araujo stage: -> needs patch ___ Python tra

[issue12386] packaging fails in install_distinfo when writing RESOURCES

Changes by Vinay Sajip : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue12386] packaging fails in install_distinfo when writing RESOURCES

New submission from Vinay Sajip : This part of install_distinf.run(): if install_data.get_resources_out() != []: resources_path = os.path.join(self.distinfo_dir, 'RESOURCES') logger.info('creating %s', resources_path) with open(re