[issue12019] Dead or buggy code in importlib.test.__main__

Éric Araujo added the comment: I checked the patch again with ./python -m importlib.test and ./python Lib/importlib/test and committed. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue12019] Dead or buggy code in importlib.test.__main__

Roundup Robot added the comment: New changeset 5392be94ea65 by Éric Araujo in branch 'default': Kill dead code in importlib.test.__main__ (#12019, reviewed by Brett Cannon) http://hg.python.org/cpython/rev/5392be94ea65 -- nosy: +python-dev ___ Python

[issue12019] Dead or buggy code in importlib.test.__main__

Éric Araujo added the comment: Agreed; I didn’t mean to imply that strict was restrictive, but that it was safe. -- ___ Python tracker ___ _

[issue12019] Dead or buggy code in importlib.test.__main__

Georg Brandl added the comment: I don't think our policy is that strict, i.e. I wouldn't revert the change if it was already committed. But it's a bit slippery, and I'd rather have no behavior-changing "cleanups" end up in 3.2 originating in good intentions. -- status: pending -> ope

[issue12019] Dead or buggy code in importlib.test.__main__

Éric Araujo added the comment: Brett: Merging is hardly a hassle for me, nor would it take any time in this case (non-conflicting changes are applied by Mercurial itself). I handle merges in projects that use multiple repositories, tons of clones, translation branches, so I’m a merge master

[issue12019] Dead or buggy code in importlib.test.__main__

Georg Brandl added the comment: If it's a minor cleanup and not a bugfix, why should it go into a branch that receives bugfixes only? -- nosy: +georg.brandl ___ Python tracker

[issue12019] Dead or buggy code in importlib.test.__main__

Brett Cannon added the comment: Sure, but I'm not even sure it's worth the hassle of dealing with the merge. If you want to put in the time then that's fine, but I don't think it's worth it. -- ___ Python tracker

[issue12019] Dead or buggy code in importlib.test.__main__

Éric Araujo added the comment: Is this minor cleanup, non-bugfix okay for 3.2? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue12019] Dead or buggy code in importlib.test.__main__

Brett Cannon added the comment: Yeah, it's dead code so go ahead and rip it out. -- assignee: -> eric.araujo ___ Python tracker ___

[issue12019] Dead or buggy code in importlib.test.__main__

Éric Araujo added the comment: I read again the part of the PEP about __file__ and decided the code is a dead branch, so I removed it. -- keywords: +needs review, patch stage: -> commit review Added file: http://bugs.python.org/file22150/dead-code-importlib-test-main-3.3.diff __

[issue12019] Dead or buggy code in importlib.test.__main__

New submission from Éric Araujo : I was stealing importlib’s test/__main__ file for packaging (thanks!) and I noticed this bug thanks to pyflakes: “sep” is undefined. It looks like the bug hasn’t been noticed because it’s in a dead block that depends on __file__ containing '__pycache__'. Is