[issue11841] Bug in the verson comparison

2011-10-06 Thread Éric Araujo
Éric Araujo added the comment: I couldn’t reproduce the bugs but added the tests. Thanks! -- resolution: -> out of date stage: -> committed/rejected status: open -> closed versions: +3rd party ___ Python tracker

[issue11841] Bug in the verson comparison

2011-10-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2105ab8553b7 by Éric Araujo in branch 'default': Add tests for comparing candidate and final versions in packaging (#11841). http://hg.python.org/cpython/rev/2105ab8553b7 -- nosy: +python-dev ___ Python

[issue11841] Bug in the verson comparison

2011-04-15 Thread Filip Gruszczyński
Filip Gruszczyński added the comment: I understand that ML is mailing list, but I have no idea what is fellowship mailing list. Could you elaborate on this? -- ___ Python tracker _

[issue11841] Bug in the verson comparison

2011-04-15 Thread Éric Araujo
Éric Araujo added the comment: > I think it's a common practice to create constants for such hardcoded > values. Yep, _FINAL_MARKER is clearer here that a cryptic character. An alternate fix would be to use a c as rc marker (like what Python itself does in sys.hexversion and elsewhere). I’l

[issue11841] Bug in the verson comparison

2011-04-15 Thread Filip Gruszczyński
Filip Gruszczyński added the comment: The reason for the use of two constants is that previously there was comparison in the code with a hardcoded 'f': if postdev[0] == 'f': I think it's a common practice to create constants for such hardcoded values. Also this hit when I was mak

[issue11841] Bug in the verson comparison

2011-04-15 Thread Éric Araujo
Éric Araujo added the comment: Thanks, looks great! Why does the code use both a string and a singleton tuple? -- ___ Python tracker ___ ___

[issue11841] Bug in the verson comparison

2011-04-13 Thread Filip Gruszczyński
Filip Gruszczyński added the comment: Here is a patch that I made against distutils2 tip. I have changed _FINAL_MARKER from 'f' to 'z', which works with rc. Also I have added constant _FINAL_MARKER_CHAR, since later in the code you make a check against 'f' and it surprised me a little at firs

[issue11841] Bug in the verson comparison

2011-04-13 Thread Tarek Ziadé
New submission from Tarek Ziadé : The NormalizedVersion class is not correctly sorting rc1: >>> from packaging.version import NormalizedVersion >>> NormalizedVersion('0.7.0') < NormalizedVersion('0.7.0rc1') True >>> NormalizedVersion('0.7.0rc1') NormalizedVersion('0.7rc1') >>> NormalizedVersion(