[issue11729] libffi assembler relocation check is not robust, fails with clang

Roundup Robot added the comment: New changeset 7a2e0c1bb1a9 by Gregory P. Smith in branch '3.2': * Fix issue 17192 for 3.2 - reapply the issue11729 patch that was undone http://hg.python.org/cpython/rev/7a2e0c1bb1a9 New changeset aa3371fa9773 by Gregory P. Smith in branch '3.3': * Fix PART of is

[issue11729] libffi assembler relocation check is not robust, fails with clang

Roundup Robot added the comment: New changeset b9792b27d410 by Stefan Krah in branch '2.7': Issue #11729: Backport commit bff052d9 from libffi upstream in order to fix http://hg.python.org/cpython/rev/b9792b27d410 -- ___ Python tracker

[issue11729] libffi assembler relocation check is not robust, fails with clang

Benjamin Peterson added the comment: Okay with me to backport. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue11729] libffi assembler relocation check is not robust, fails with clang

Stefan Krah added the comment: The buildbot coverage is good, but the number of (OS, shell, compiler) combinations is much higher. -- ___ Python tracker ___ _

[issue11729] libffi assembler relocation check is not robust, fails with clang

koobs added the comment: Thanks for the quick response. I'd be happy for it to be FreeBSD conditional/specific if that's more suitable, safer? Having said that, our buildbot OS coverage is pretty good, no? -- ___ Python tracker

[issue11729] libffi assembler relocation check is not robust, fails with clang

Stefan Krah added the comment: koobs wrote: > Stefan, can we merge this to the 2.7 branch as well please? If Benjamin is okay with it, yes. The problem with these configure fixes is that they might break other systems in unexpected ways. I already hesitated to put it into 3.3, but the buildbot

[issue11729] libffi assembler relocation check is not robust, fails with clang

koobs added the comment: Stefan, can we merge this to the 2.7 branch as well please? http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.0%20dtrace%2Bclang%202.7/builds/308/steps/compile/logs/stdio -- nosy: +koobs ___ Python tracker

[issue11729] libffi assembler relocation check is not robust, fails with clang

Stefan Krah added the comment: Thanks for the link. The diff was committed last week to the upstream libffi development tree, so I backported it. -- assignee: -> skrah resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> behavior versions: +Python 3.4 __

[issue11729] libffi assembler relocation check is not robust, fails with clang

Roundup Robot added the comment: New changeset 190a115b7748 by Stefan Krah in branch '3.3': Issue #11729: Backport commit bff052d9 from libffi upstream in order to fix http://hg.python.org/cpython/rev/190a115b7748 -- nosy: +python-dev ___ Python track

[issue11729] libffi assembler relocation check is not robust, fails with clang

Ismail Donmez added the comment: See http://sourceware.org/ml/libffi-discuss/2011/msg00024.html for the libffi patch. -- ___ Python tracker ___ _

[issue11729] libffi assembler relocation check is not robust, fails with clang

Stefan Krah added the comment: In 3.3 libffi has been updated to 3.0.11. Our clang buildbot does not show this particular warning, but still fails to compile libffi: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.0%20dtrace%2Bclang%203.3/builds/320/steps/compile/logs/stdio It woul

[issue11729] libffi assembler relocation check is not robust, fails with clang

Changes by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue11729] libffi assembler relocation check is not robust, fails with clang

Éric Araujo added the comment: See also #12081. -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue11729] libffi assembler relocation check is not robust, fails with clang

Ismail Donmez added the comment: Patch for configure.ac then? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue11729] libffi assembler relocation check is not robust, fails with clang

Changes by Antoine Pitrou : -- nosy: +doko ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue11729] libffi assembler relocation check is not robust, fails with clang

Antoine Pitrou added the comment: Well, ctypes is kindof unmaintained right now, and the private libffi copy belongs to that module. (the reason we have a libffi copy is that, IIUC, it's patched) -- nosy: +pitrou ___ Python tracker

[issue11729] libffi assembler relocation check is not robust, fails with clang

Ismail Donmez added the comment: Ping? Shall I submit a fix for Modules/_ctypes/libffi/configure.ac or better yet will you sync in-tree libffi? -- ___ Python tracker ___ __

[issue11729] libffi assembler relocation check is not robust, fails with clang

Changes by Raymond Hettinger : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue11729] libffi assembler relocation check is not robust, fails with clang

Arfrever Frehtes Taifersar Arahesis added the comment: Internal copies of third-party libraries are rather always outdated, so it's better to always use system libraries. IMHO Python shouldn't bundle any third-party libraries and should force users to use system libraries. At least, system li

[issue11729] libffi assembler relocation check is not robust, fails with clang

Ismail Donmez added the comment: Yes I can workaround it but I'd like to get it fixed inside Python too ;) -- ___ Python tracker ___

[issue11729] libffi assembler relocation check is not robust, fails with clang

Arfrever Frehtes Taifersar Arahesis added the comment: You can install the newest libffi and pass --with-system-ffi option to main `configure` of Python. -- nosy: +Arfrever ___ Python tracker

[issue11729] libffi assembler relocation check is not robust, fails with clang

Ismail Donmez added the comment: This is already fixed in upstream, check has been changed into: libffi_cv_as_x86_pcrel=no echo '.text; foo: nop; .data; .long foo-.; .text' > conftest.s if $CC $CFLAGS -c conftest.s > /dev/null; then libffi_cv_as_x86_pcrel=yes fi ]) --

[issue11729] libffi assembler relocation check is not robust, fails with clang

Benjamin Peterson added the comment: I suggest you complain to the libffi maintainers. -- nosy: +benjamin.peterson ___ Python tracker ___ ___

[issue11729] libffi assembler relocation check is not robust, fails with clang

New submission from Ismail Donmez : The check under Modules/_ctypes/libffi/configure.ac does; echo '.text; foo: nop; .data; .long foo-.; .text' > conftest.s if $CC $CFLAGS -c conftest.s 2>&1 | grep -i warning > /dev/null; then libffi_cv_as_x86_pcrel=no fi With clang; we ge