[issue11616] reap_children should not use WNOHANG

2011-03-20 Thread Antoine Pitrou
Antoine Pitrou added the comment: Probably a bad idea on my part :) -- resolution: -> rejected status: open -> closed ___ Python tracker ___ ___

[issue11616] reap_children should not use WNOHANG

2011-03-20 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I'm not sure. Was reap_children() meant to just reap zombie processes > or wait for all children to finish? Apparently just to reap zombie processes. At least that was the initial intent. And it's true that we don't really need to collect all children immedia

[issue11616] reap_children should not use WNOHANG

2011-03-20 Thread Ross Lagerwall
Ross Lagerwall added the comment: I'm not sure. Was reap_children() meant to just reap zombie processes or wait for all children to finish? It seems like it was written to just reap zombie processes. Might this not cause hangs during testing sometimes if a subprocess that was started has its

[issue11616] reap_children should not use WNOHANG

2011-03-20 Thread Antoine Pitrou
New submission from Antoine Pitrou : Using WNOHANG means that still-running children won't get collected. This seems to defeat the point of reap_children(). This patch seems to work: diff -r adbdb3e74461 Lib/test/support.py --- a/Lib/test/support.py Sun Mar 20 17:36:26 2011 +0100 +++ b/L