[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset 7e3ed426962f by Victor Stinner in branch 'default': Issue #11393: _Py_DumpTraceback() writes the header even if there is no frame http://hg.python.org/cpython/rev/7e3ed426962f New changeset e609105dff64 by Victor Stinner in branch 'default': Issue

[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset a27755b10448 by Victor Stinner in branch 'default': Issue #11393: Fix faulthandler.disable() and add a test http://hg.python.org/cpython/rev/a27755b10448 -- ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset e51d8a160a8a by Victor Stinner in branch 'default': Issue #11393: fault handler uses raise(signum) for SIGILL on Windows http://hg.python.org/cpython/rev/e51d8a160a8a New changeset a4fa79b0d478 by Victor Stinner in branch 'default': Issue #11393: T

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: The last commits fixed test_faulthandler on FreeBSD, there are no more faulthandler bugs. Close this issue gain. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset 3558eecd84f0 by Victor Stinner in branch 'default': Issue #11393: fix usage of locks in faulthandler http://hg.python.org/cpython/rev/3558eecd84f0 -- ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset 0fb0fbd442b4 by Victor Stinner in branch 'default': Issue #11393: New try to fix faulthandler_thread() http://hg.python.org/cpython/rev/0fb0fbd442b4 -- ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

Antoine Pitrou added the comment: > New changeset 8b1341d51fe6 by Victor Stinner in branch 'default': > Issue #11393: Fix faulthandler_thread(): release cancel lock before join lock > http://hg.python.org/cpython/rev/8b1341d51fe6 This is wrong, it should always be released, not only when explic

[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset 8b1341d51fe6 by Victor Stinner in branch 'default': Issue #11393: Fix faulthandler_thread(): release cancel lock before join lock http://hg.python.org/cpython/rev/8b1341d51fe6 -- ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: Cool, 69f58be4688a fixed all failures (all related to dump_backtraces_later()) on "x86 XP-4 3.x". So "PPC Leopard" should also be fixed. -- ___ Python tracker ___

[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset 69f58be4688a by Victor Stinner in branch 'default': Issue #11393: test_faulthandler is more tolerant on inaccurate time http://hg.python.org/cpython/rev/69f58be4688a -- ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: Other failures on "x86 XP-4 3.x": http://www.python.org/dev/buildbot/all/builders/x86%20XP-4%203.x/builds/4308 == FAIL: test_dump_tracebacks_later (test.test_faulthandler.FaultHandlerTests) ---

[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset 61626c3f3a54 by Victor Stinner in branch 'default': Issue #11393: get more information on assertion error (test_faulthandler) http://hg.python.org/cpython/rev/61626c3f3a54 -- ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset e91de993964c by Victor Stinner in branch 'default': Issue #11393: check that stdout is empty if we use a file http://hg.python.org/cpython/rev/e91de993964c -- ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: Same issue on PPC Leopard custom: [224/354] test_faulthandler test test_faulthandler failed -- Traceback (most recent call last): File "/Users/buildbot/buildarea/custom.parc-leopard-1/build/Lib/test/test_faulthandler.py", line 412, in test_dump_tracebacks_l

[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset aa2ac1581d23 by Victor Stinner in branch 'default': Issue #11393: test_faulthandler checks the exitcode after the output http://hg.python.org/cpython/rev/aa2ac1581d23 -- ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

Antoine Pitrou added the comment: There is a failure on FreeBSD: == FAIL: test_dump_tracebacks_later_repeat (test.test_faulthandler.FaultHandlerTests) -- Trac

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: I opened #11727 for the patch on regrtest.py. All buildbots look happy (no more failure on test_faulthandler), so let's close this issue. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: test_faulthandler blocked AMD64 Gentoo Wide 3.x and AMD64 OpenIndiana 3.x buildbots because of the stack overflow test. > New changeset e289b64f355d by Victor Stinner in branch 'default': > Issue #11393: limit stack overflow test to 100 MB > http://hg.python.o

[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset a6d2c703586a by Victor Stinner in branch 'default': Issue #11393: Fix the documentation (cancel_dump_traceback_later) http://hg.python.org/cpython/rev/a6d2c703586a New changeset e289b64f355d by Victor Stinner in branch 'default': Issue #11393: limi

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: stack_overflow.patch should fix AMD64 Gentoo Wide 3.x and AMD64 OpenIndiana 3.x failures. I schedule a test on their custom slaves, but these buildbots are still running test_faulthandler on their 3.x slaves. I interrupted the test, but it doesn't work (click

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: I disabled test_stack_overflow because the test fails on AMD64 Gentoo Wide 3.x, and maybe other buildbots (AMD64 OpenIndiana 3.x?). I fear that the test uses a lot of CPU, memory and/or swap. -- ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset 25a2aeecb34b by Victor Stinner in branch 'default': Issue #11393: Disable test_stack_overflow of test_faulthandler http://hg.python.org/cpython/rev/25a2aeecb34b -- ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: test_faulthandler failed also on AMD64 OpenIndiana 3.x: regrtest.py (only executing test_faulthandler) was killed after 11 min 20 sec. -- ___ Python tracker _

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: First failure: AMD64 Gentoo Wide 3.x. http://www.python.org/dev/buildbot/all/builders/AMD64%20Gentoo%20Wide%203.x/builds/1363/ [1/1] test_faulthandler test test_faulthandler failed -- Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.ocht

[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset df240014e72f by Victor Stinner in branch 'default': Issue #11393: reenable all tests in regrtest.py (wooops, sorry Antoine) http://hg.python.org/cpython/rev/df240014e72f -- ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

Roundup Robot added the comment: New changeset b0680b5a5215 by Victor Stinner in branch 'default': Issue #11393: Add the new faulthandler module http://hg.python.org/cpython/rev/b0680b5a5215 -- nosy: +python-dev ___ Python tracker

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : Added file: http://bugs.python.org/file21483/d4902114f720.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: http://hg.python.org/features/faulthandler/rev/0943ef33495a should fix test_faulthandler to support SIGBUS on reading from NULL. But it doesn't fix the failure on SIGFPE yet. I'm running the buildbot to check if it's better or not. -- __

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: I merged the faulthandler branch into the default branch. I removed __version__ field: the Python version should be enough. I also fixed an infinite loop raised by test_capi. test_faulthandler pass on Solaris and OpenIndiana, but it fails on PPC: =

[issue11393] Integrate faulthandler module into Python 3.3

Antoine Pitrou added the comment: > - speed up the test: because dump_backtraces_later() has now a > subsecond resolution, we can use sleep of 50 ms instead of 1 sec This is too short, there may be random failures on some slow buildbots. IMO, 0.5s is the minimum you can use. +def _check_d

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: > My TODO list is empty (the last item was "fix register() to be signal > safe") so I think that the patch is ready to be commited. As I wrote, I did some tests on FreeBSD, found bugs and fixed them. I also fixed the weird behaviour if the user sends manually

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : Removed file: http://bugs.python.org/file21474/4adbea7c832e.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : Added file: http://bugs.python.org/file21476/f5a11df83d98.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : Removed file: http://bugs.python.org/file21470/a979bb83a94b.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : Added file: http://bugs.python.org/file21474/4adbea7c832e.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: > faulthandler_fatal_error() calls the previous signal handler > using raise(signum) It doesn't work as expected on Windows: Windows doesn't call its own signal handler anymore. Use the previous code (only on Windows). I also added a test for stack overflow:

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : Removed file: http://bugs.python.org/file21467/c684b1e59aaa.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : Added file: http://bugs.python.org/file21470/a979bb83a94b.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: > > - speed up the test: because dump_backtraces_later() has now a > > subsecond resolution, we can use sleep of 50 ms instead of 1 sec > > This is too short, there may be random failures on some slow buildbots. > IMO, 0.5s is the minimum you can use. Ok, cha

[issue11393] Integrate faulthandler module into Python 3.3

Antoine Pitrou added the comment: > - speed up the test: because dump_backtraces_later() has now a > subsecond resolution, we can use sleep of 50 ms instead of 1 sec This is too short, there may be random failures on some slow buildbots. IMO, 0.5s is the minimum you can use. +def _check_d

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: Remainder for me: the patch contains some whitespace changes in Makefile.pre.in and Setup.dist. dump_traceback(), enable(), dump_tracebacks_later(), register() flush the input file. It is not said in the doc. Should it be documented? For enable(), dump_trace

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: I regenerated the patch. Last changes: - I merged Antoine's new implementation of faulthandler.dump_backtraces_later() using a thread - dump_backtraces_later() has a new exit option: if exit=True, call _exit() - disable (remove) register() and unregister()

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : Removed file: http://bugs.python.org/file21404/605422430234.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : Added file: http://bugs.python.org/file21467/c684b1e59aaa.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: regrtest_timeout.patch: add --timeout option to regrtest.py to display the traceback and then exit if a test takes more than TIMEOUT seconds. It adds also a check on the subprocess exit code (regrtest.py -j): raise a exception if it is different than zero. -

[issue11393] Integrate faulthandler module into Python 3.3

Antoine Pitrou added the comment: I have pushed a new branch "faulthandler-thread" in http://hg.python.org/features/faulthandler/. It contains an implementation of dump_tracebacks_later() using a watchdog thread, instead of alarm(). It has two advantages: - it works under Windows - it won't d

[issue11393] Integrate faulthandler module into Python 3.3

Antoine Pitrou added the comment: > I updated the (Hg repo and the) patch to fix all Antoine's remarks. Can you make the suggested changes to the tests? Thank you. -- ___ Python tracker __

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: New patch 605422430234.diff: - Remove test_refcount(), it changed faulthandler internal state, and so it was no more possible to use faulthandler in regrtest.py - Use "#ifdef HAVE_ALARM" to decide if dump_traceback_later() is available, instead of "#ifdef SI

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : Added file: http://bugs.python.org/file21404/605422430234.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : Removed file: http://bugs.python.org/file21403/174bc8c03e9d.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: I don't know if it is important to document that some functions keep an internal reference to the file argument. For example, I wrote "It keeps a reference to file: use disable() to clear this reference." in faulthandler.enable() documentation. Is it necessar

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: I updated the (Hg repo and the) patch to fix all Antoine's remarks. -- ___ Python tracker ___ ___ P

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : Removed file: http://bugs.python.org/file21393/ec274420e9e2.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : Added file: http://bugs.python.org/file21403/174bc8c03e9d.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue11393] Integrate faulthandler module into Python 3.3

Antoine Pitrou added the comment: I've posted a review at http://bugs.python.org/review/11393/show. -- ___ Python tracker ___ ___ Pyt

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: (Reminder for me: add something to Doc/whatsnew/3.3.rst and Misc/NEWS) -- ___ Python tracker ___ __

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: Ok, here is a full patch tested on Linux and Windows: - Add faulthandler module (code, doc, tests) as a builtin module - Add "-X faulthandler=1" command line option and PYTHONFAULTHANDLER=1 en var to enable the fault handler at startup - Add _Py_DumpTracebac

[issue11393] Integrate faulthandler module into Python 3.3

Changes by STINNER Victor : -- keywords: +patch Added file: http://bugs.python.org/file21393/ec274420e9e2.diff ___ Python tracker ___

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: Let's try the "Remote hg repo" feature. -- hgrepos: +8 ___ Python tracker ___ ___ Python-bugs-list

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: > For fatal errors, you needn't be async-safe, so the fatal error code > could read fileno(stderr) and give it to the traceback printing code. My last patch for issue #8863 does exactly that: ## void Py_FatalError(const char *msg) { -fprintf

[issue11393] Integrate faulthandler module into Python 3.3

Antoine Pitrou added the comment: > Antoine Pitrou wrote: > > It would be nice if it were enabled by default for fatal errors (and > > asserts perhaps?). > > I feel like a broken record. This code hardcodes fd=2 as a write target on > crash, For fatal errors, you needn't be async-safe, so th

[issue11393] Integrate faulthandler module into Python 3.3

Scott Dial added the comment: Antoine Pitrou wrote: > It would be nice if it were enabled by default for fatal errors (and asserts > perhaps?). I feel like a broken record. This code hardcodes fd=2 as a write target on crash, which is not safe thing to do at all. You can argue that adopters o

[issue11393] Integrate faulthandler module into Python 3.3

Marc-Andre Lemburg added the comment: STINNER Victor wrote: > > STINNER Victor added the comment: > > Le mardi 22 mars 2011 à 09:01 +, Marc-Andre Lemburg a écrit : >> Perhaps you could consider adding a similar approach (raising >> an exception instead of writing a traceback) to the modul

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: Le mardi 22 mars 2011 à 09:01 +, Marc-Andre Lemburg a écrit : > Perhaps you could consider adding a similar approach (raising > an exception instead of writing a traceback) to the module. > We could then port our code to use your module, which is > more adva

[issue11393] Integrate faulthandler module into Python 3.3

Marc-Andre Lemburg added the comment: STINNER Victor wrote: > > STINNER Victor added the comment: > >> It would be nice if it were enabled by default for fatal errors >> (and asserts perhaps?). > > That would mean that the module should be a builtin module, or that it is > always loaded in

[issue11393] Integrate faulthandler module into Python 3.3

Changes by Andreas Stührk : -- nosy: +Trundle ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: > It would be nice if it were enabled by default for fatal errors > (and asserts perhaps?). That would mean that the module should be a builtin module, or that it is always loaded in memory. I am maybe ok to enable it by default for debug builds, but not for

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: I renamed some functions to conform to the PEP 8 (and have more readable function names). I prefer to do it today instead having to keep ugly names for years :-) Functions are now: * enable(file=sys.stderr, all_threads=False) * disable() * is_enabled()

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: > Ok, good idea, I will do that. I think that I will write it in the > function comment, something like: "This function is signal safe". Done in 6685691dfcbd3644feffcb197491bce3168ff5de (git SHA-1) While checking the usage of signal safe functions, I found a b

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: Le lundi 21 mars 2011 à 15:59 +, Dave Malcolm a écrit : > Various thoughts/nitpicking: > - is it possible to indicate with a coding convention (e.g. > comments) which parts of the code are intended to be called from a > signal handler? It seems worth maki

[issue11393] Integrate faulthandler module into Python 3.3

Dave Malcolm added the comment: Various thoughts/nitpicking: - is it possible to indicate with a coding convention (e.g. comments) which parts of the code are intended to be called from a signal handler? It seems worth making this explicit. Or perhaps put it all in one file? - within tes

[issue11393] Integrate faulthandler module into Python 3.3

Antoine Pitrou added the comment: It would be nice if it were enabled by default for fatal errors (and asserts perhaps?). -- nosy: +pitrou ___ Python tracker ___ __

[issue11393] Integrate faulthandler module into Python 3.3

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue11393] Integrate faulthandler module into Python 3.3

STINNER Victor added the comment: I tested faulthandler on Linux, FreeBSD and Windows XP: it works well. I suppose that it works on any operating systems. You can also try it on know crashers: Lib/test/crashers/ (you have to modify the files to add: import faulthandler; faulthandler.enable())

[issue11393] Integrate faulthandler module into Python 3.3

Changes by Antoine Pitrou : -- nosy: +dmalcolm ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue11393] Integrate faulthandler module into Python 3.3

New submission from STINNER Victor : << Fault handler for SIGSEGV, SIGFPE, SIGBUS and SIGILL signals: display the Python backtrace and restore the previous handler. Allocate an alternate stack for this handler, if sigaltstack() is available, to be able to allocate memory on the stack, even on sta