[issue11078] Have test___all__ check for duplicates

Changes by Ezio Melotti : -- assignee: -> ezio.melotti resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue11078] Have test___all__ check for duplicates

Roundup Robot added the comment: New changeset 3f1bcfbed022 by Ezio Melotti in branch 'default': #11078: test___all__ now checks for duplicates in __all__. Initial patch by R. David Murray. http://hg.python.org/cpython/rev/3f1bcfbed022 -- nosy: +python-dev

[issue11078] Have test___all__ check for duplicates

Ezio Melotti added the comment: Attached an updated patch that also uses subtests to keep running all tests even in case of failure. The patch also intentionally breaks a few __all__ to show how it works -- these changes should clearly be removed once the patch gets committed. -- nosy:

[issue11078] Have test___all__ check for duplicates

Changes by Alexander Belopolsky : -- dependencies: +from struct import * misses pack_into ___ Python tracker ___ ___ Python-bugs-list

[issue11078] Have test___all__ check for duplicates

R. David Murray added the comment: Well, checking if the token is there before adding it would certainly be a fix, but I think it would be worth understanding why it gets added if it is already there, because instead perhaps it is possible to simply remove the adding code from os.py. Removin

[issue11078] Have test___all__ check for duplicates

Alexander Belopolsky added the comment: On Mon, Jan 31, 2011 at 12:09 PM, R. David Murray wrote: .. > On linux, the dups are putenv and unsetenv.  And yes, deeper investigation of > why > os.py is adding them is required to fix this :) Too bad __all__ cannot be specified as a set. --

[issue11078] Have test___all__ check for duplicates

R. David Murray added the comment: Well, the test stops testing after the first failure. Perhaps another enhancement request would be to make test__all__ a parameterized test so that it tests all modules even if one or more fail. On linux, the dups are putenv and unsetenv. And yes, deeper i

[issue11078] Have test___all__ check for duplicates

SilentGhost added the comment: At the moment test fails only for os module on windows. These are the offending names: putenv, spawnv, spawnve The reason is that __all__ is extended with ntpath.__all__ and then again in the body of os.py (I'm not entirely sure how this could be fixed elegantl

[issue11078] Have test___all__ check for duplicates

Alexander Belopolsky added the comment: +1. This is a fairly common mistake. Usually benign, but as issue 8973 shows, may highlight a visible error. -- nosy: +belopolsky ___ Python tracker _

[issue11078] Have test___all__ check for duplicates

New submission from R. David Murray : Inspired by what happened in issue 8973, I offer the attached patch for test__all__ to have it check the __all__ list for duplicates. Interestingly, the first failure is not in struct, but in os. Obviously the patch can't be applied until the test succee