[issue10966] eliminate use of ImportError implicitly representing TestSkipped

2011-02-09 Thread Brett Cannon
Brett Cannon added the comment: Here is a patch which has added the necessary changes to test.support.import_module() and placed the necessary changes in the test suites themselves. I still need to rip out the (un)expected test stuff from regrtest before I consider the patch complete. --

[issue10966] eliminate use of ImportError implicitly representing TestSkipped

2011-01-21 Thread R. David Murray
R. David Murray added the comment: Ah, I see what you are getting at now. I was confused by the "raise SkipTest directly" part, since the test suite currently does raise SkipTest instead of ImportError. So the key change here is to make the test show as a *failure* on those platforms where

[issue10966] eliminate use of ImportError implicitly representing TestSkipped

2011-01-21 Thread Brett Cannon
Brett Cannon added the comment: Yes. So for _winreg (if we even have tests) it would be skipped on all OSs other than Windows, on on Windows it would be a test failure if it didn't work as it is expected to exist. -- ___ Python tracker

[issue10966] eliminate use of ImportError implicitly representing TestSkipped

2011-01-21 Thread R. David Murray
R. David Murray added the comment: On second reading I see one way it is different: you suggest to move the list of expected skips out of regrtest. So, are you suggesting, essentially, that support.import_module be replaced by an optional_import that takes arguments to indicate on which plat

[issue10966] eliminate use of ImportError implicitly representing TestSkipped

2011-01-21 Thread R. David Murray
R. David Murray added the comment: How is this different from issue 2409? -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-

[issue10966] eliminate use of ImportError implicitly representing TestSkipped

2011-01-20 Thread Brett Cannon
Brett Cannon added the comment: Once the proper function in test.support comes about then a dev task to help move everything over can be created. And then once all needed test modules have been switched over the ImportError try/except statement in regrtest can be removed. -- ___

[issue10966] eliminate use of ImportError implicitly representing TestSkipped

2011-01-20 Thread Brett Cannon
New submission from Brett Cannon : test.regrtest considers an ImportError to be a test to skip. It then uses this info to decide what skipped tests were expected (or not) based on a list kepted in regrtest.py. For detecting compiler failures, an ImportError should be a test error or failure.