[issue10432] concurrent.futures.as_completed() spins waiting for futures to complete

2010-11-17 Thread Scott Dial
Scott Dial added the comment: Good catch. I suppose it was inevitable when I transferred my changes into a SVN checkout that I missed something. Nevertheless, your changeset in r86491 matches my own. Thanks! -- ___ Python tracker

[issue10432] concurrent.futures.as_completed() spins waiting for futures to complete

2010-11-17 Thread Georg Brandl
Georg Brandl added the comment: Please mention the issue number in the commit message when applying patches or bugfixes. -- nosy: +georg.brandl ___ Python tracker ___ _

[issue10432] concurrent.futures.as_completed() spins waiting for futures to complete

2010-11-17 Thread Brian Quinlan
Brian Quinlan added the comment: Looks good but you forgot to actually use your new Waiter ;-) Committed as r86491. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue10432] concurrent.futures.as_completed() spins waiting for futures to complete

2010-11-16 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> bquinlan nosy: +bquinlan stage: -> patch review versions: -Python 3.3 ___ Python tracker ___ _

[issue10432] concurrent.futures.as_completed() spins waiting for futures to complete

2010-11-16 Thread Scott Dial
New submission from Scott Dial : The code in as_completed() waits on a FIRST_COMPLETED event, which means that after the first future completes, it will no longer wait at all. The proposed patch adds a _AsCompletedWaiter and uses a lock to swap out the finished list and reset the event. This