[issue41906] logging.config.dictConfig does not work with callable filters

2020-10-21 Thread lorb
lorb added the comment: I looked into implementing this and it's not entirely clear how it could work. The main issue I encountered is how to distinguish between a callable that is a factory that takes one argument and a callable that is a filter. One possible approach I see is to re

[issue39826] logging HTTPHandler does not support proxy

2020-03-02 Thread lorb
Change by lorb : -- keywords: +patch pull_requests: +18099 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18745 ___ Python tracker <https://bugs.python.org/issu

[issue39826] logging HTTPHandler does not support proxy

2020-03-02 Thread lorb
New submission from lorb : The HTTPHandler does not support using a proxy. It would be necessary to subclass it and reimplement `emit` to enable passing in proxy settings. Adding a hook to make it easy to customize the connection used would solve this. -- components: Library (Lib

[issue38716] logging: rotating handlers set namer and rotator null

2019-11-06 Thread lorb
lorb added the comment: I have changed the PR accordingly. Am Mi., 6. Nov. 2019 um 16:36 Uhr schrieb Vinay Sajip : > > > Vinay Sajip added the comment: > > > Would you consider it more acceptable to just turn > them into class level attributes of BaseRotatingHandler inst

[issue38716] logging: rotating handlers set namer and rotator null

2019-11-06 Thread lorb
lorb added the comment: This PR certainly does not turn them into methods. I believe it also doesn't encourage the idea that they would have to be. All it does is preventing __init__ from setting them to None in the case they are defined as methods. Would you consider it more acceptab

[issue38716] logging: rotating handlers set namer and rotator null

2019-11-06 Thread lorb
lorb added the comment: Thanks for the review and response. I don't understand yet why not to allow the following while keeping the existing functionality. This could also be achieved by turning the namer and rotator into class attributes. I recently created a subclass of the timed rot

[issue38716] logging: rotating handlers set namer and rotator null

2019-11-06 Thread lorb
Change by lorb : -- keywords: +patch pull_requests: +16581 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17072 ___ Python tracker <https://bugs.python.org/issu

[issue38716] logging: rotating handlers set namer and rotator null

2019-11-06 Thread lorb
New submission from lorb : When subclassing the rotating handlers of the logging module and implementing a namer or rotator method they are silently set to None in __init__. This is surprising behaviour and currently the set a specific namer or rotator it is required to create an instance