Petter Haggholm added the comment:
Added suggested changes from review, removed (rather useless) repr test; left
parse.py changes alone (see review comments for rationale)
--
Added file: http://bugs.python.org/file22715/urlparsetest.patch
Petter Haggholm added the comment:
It’s my pleasure — it’s very trivial, but hopefully it’ll get my feet wet and
get me in a place where I am familiar enough with procedures and things to
contribute something relevant. :)
Attaching a modified patch with (1) reversion to duck typing in
New submission from Petter Haggholm :
Some very trivial tests to increase the test coverage on test_urlparse a bit;
also changed a single line to use an ABC instead of attempting to use len() to
verify that an object is "sequence-like" (as the comment put it). Mostly I’m
trying to g