Marek Šuppa added the comment:
That is probably right.
I was way too foolish to start with this but won't stop now.
I'll try to iterate on your feedback.
Thanks!
--
___
Python tracker
<http://bugs.python.o
Marek Šuppa added the comment:
Thanks for the review.
Do you think I should split it into multiple patches to make it easier to look
through?
It might be that some changes are completely wrong. This is the first time I
did something with cpython core code
Marek Šuppa added the comment:
So what do you think should be done here?
Just removing the "or --repository=" part?
--
nosy: +mrshu
___
Python tracker
<http://bugs.python.o
Marek Šuppa added the comment:
Any update on this?
--
___
Python tracker
<http://bugs.python.org/issue15948>
___
___
Python-bugs-list mailing list
Unsubscribe:
Marek Šuppa added the comment:
Hi,
Sorry for the long delay.
The attached patch should fix all the relevant occurrences of I/O functions I
was able to find.
Please review.
Thanks!
--
Added file: http://bugs.python.org/file28253/unchecked_return_values.patch
Marek Šuppa added the comment:
Appended is the patch for _cursesmodule.c
Let me know if it's OK.
--
keywords: +patch
Added file: http://bugs.python.org/file27692/issue15948__cursesmodule.patch
___
Python tracker
<http://bugs.python.org/is
Marek Šuppa added the comment:
Thanks for a quick response.
Should we also test this somewhere?
Christian Heimes wrote:
>
>Christian Heimes added the comment:
>
>The functions should set an appropriate errno so it's
>PyErr_SetFromErrno(PyExc_IOError)
Marek Šuppa added the comment:
Since there is probably a lot to work on here I'd also like to participate.
I've got one question though. In case these function don't return 0 and the
test fails what should happen then? What kind of error should be thrown for
Marek Šuppa added the comment:
I already filled and signed the PSF Contributor Agreement thanks to Petri at
the PyCon Finland sprint.
--
___
Python tracker
<http://bugs.python.org/issue16
