[issue34070] Superfluous call to isatty in open() when buffering >= 0

2018-07-08 Thread David Herberth
Change by David Herberth : -- keywords: +patch pull_requests: +7742 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue34070> ___ ___ Py

[issue34070] Superfluous call to isatty in open() when buffering >= 0

2018-07-08 Thread David Herberth
New submission from David Herberth : _iomodule.c:_io_open_impl checks for isatty even if not necessary (when buffering >= 0). Code: https://github.com/python/cpython/blob/c0ee341b29bd7d978b49272a2c0e2dcfa77404d5/Modules/_io/_iomodule.c#L392 { PyObject *