[issue11594] 2to3 does not preserve line endings

2018-04-15 Thread Aaron Ang
Aaron Ang added the comment: @Jason R. Coombs You are right. I managed to reproduce the problem with a test. It only occurs when a fix is applied. Also, I figured out that the refactoring reads in the file using `open(file, 'r')`, which basically transforms all line-endings to LF

[issue11594] 2to3 does not preserve line endings

2018-04-15 Thread Aaron Ang
Change by Aaron Ang : -- keywords: +patch pull_requests: +6181 stage: test needed -> patch review ___ Python tracker <https://bugs.python.org/issue11594> ___ _

[issue11594] 2to3 does not preserve line endings

2018-04-15 Thread Aaron Ang
Aaron Ang added the comment: I couldn't reproduce this issue. I tried reproducing this problem by extending the TestRefactoringTool class and creating two files: one file with LF line-endings and one file with CRLF line-endings. The changes that I made can be found here: https://githu

[issue31201] make test: module test that failed doesn't exist

2018-04-08 Thread Aaron Ang
Change by Aaron Ang : -- keywords: +patch pull_requests: +6119 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issue31201> ___ _

[issue28677] difficult to parse sentence structure in "When an instance attribute is referenced that isn't a data attribute"

2018-03-23 Thread Aaron Ang
Change by Aaron Ang : -- keywords: +patch pull_requests: +5952 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issue28677> ___ _