On Mon, Jun 18 2018, Klemens Nanni wrote:
> On Mon, Jun 18, 2018 at 01:40:38PM +0200, Jeremie Courreges-Anglas wrote:
>> > +EDIT_PATCHES ?=
>>
>> Should be
>>
>> EDIT_PATCHES ?= Yes
> Agreed, thanks.
>
>> > + if [ -n "$$toedit" -a "${EDIT_PATCHES:L}" != no ]; then \
>>
>> I dislike using -a an
On Mon, Jun 18, 2018 at 01:40:38PM +0200, Jeremie Courreges-Anglas wrote:
> > +EDIT_PATCHES ?=
>
> Should be
>
> EDIT_PATCHES ?= Yes
Agreed, thanks.
> > + if [ -n "$$toedit" -a "${EDIT_PATCHES:L}" != no ]; then \
>
> I dislike using -a and -o in classic test/[ commands. Even if we don't
> ca
On Sun, Jun 10 2018, Klemens Nanni wrote:
> On Sun, Jun 10, 2018 at 01:14:58PM +0200, Marc Espie wrote:
>> Style: you want to add
>> EDIT_PATCHES ?= Yes
>>
>> as well. (Set it around PATCH_CHECK_ONLY)
>>
>> New variables should always be defined, for consistency.
> Done, cheers.
>
>> > +Unless
>
More feedback or OKs for that diff?
On Sun, Jun 10, 2018 at 01:14:58PM +0200, Marc Espie wrote:
> Style: you want to add
> EDIT_PATCHES ?= Yes
>
> as well. (Set it around PATCH_CHECK_ONLY)
>
> New variables should always be defined, for consistency.
Done, cheers.
> > +Unless
> > +.Ev EDIT_PATCHES
> > +is set to
> > +.Sq \&No ,
> >
On Sun, Jun 10, 2018 at 01:00:04PM +0200, Klemens Nanni wrote:
> Updated diff marking EDIT_PATCHES with `Ev' and properly sorting it
> between ECHO_REORDER and EPOCH.
Style: you want to add
EDIT_PATCHES ?= Yes
as well. (Set it around PATCH_CHECK_ONLY)
New variables should always be defined, for
Updated diff marking EDIT_PATCHES with `Ev' and properly sorting it
between ECHO_REORDER and EPOCH.
Index: bsd.port.mk
===
RCS file: /cvs/ports/infrastructure/mk/bsd.port.mk,v
retrieving revision 1.1414
diff -u -p -r1.1414 bsd.port.mk
Thinking about it again, I'd prefer no prompt at all. A simple user
setting `EDIT_PATCHES' that can be set to "No" does the job.
Here's a new diff introducing that knob.
While here, I dropped the redundant and too specific explanation about
patch files' names and endings. update-patches(1) alread
