Re: sysutils/rofi sometimes coredumps in __vfprintf (+ similar crash in fvwm3)

2023-10-01 Thread Theo Buehler
On Sat, Sep 30, 2023 at 05:13:05PM +0200, Omar Polo wrote: > My patch was incomplete -- str was still accessed later, after the > debug printf, so a better fix was due. > > Mikhail sent my diff upstream[0], where was improved and committed[1] > a couple of hours ago. Here's an adaptation for the

Re: sysutils/rofi sometimes coredumps in __vfprintf (+ similar crash in fvwm3)

2023-09-30 Thread Omar Polo
My patch was incomplete -- str was still accessed later, after the debug printf, so a better fix was due. Mikhail sent my diff upstream[0], where was improved and committed[1] a couple of hours ago. Here's an adaptation for the version we have currently in tree. [0]: https://github.com/davatoriu

Re: sysutils/rofi sometimes coredumps in __vfprintf (+ similar crash in fvwm3)

2023-09-30 Thread Mikhail
On Sat, Sep 30, 2023 at 11:00:10AM +0200, Omar Polo wrote: > I managed to reproduce it. It doesn't seem to fail with CWM, so I run > fvwm3 inside Xephyr. > > The issue seems to be in source/xcb.c: > > (gdb) p wtitle.strings > $2 = 0xf9d9ce2ce30 "FVWM", '\004' , '\337' times>, ... > > wtitle.st

Re: Possible use after free in fvwm3 [Re: sysutils/rofi sometimes coredumps in __vfprintf (+ similar crash in fvwm3)]

2023-09-30 Thread Theo Buehler
On Sat, Sep 30, 2023 at 11:43:10AM +0100, Thomas Adam wrote: > On Sat, 30 Sept 2023 at 11:32, Theo Buehler wrote: > > Hey all, > > > === > > RCS file: patches/patch-fvwm_infostore_c > > diff -N patches/patch-fvwm_infostore_c > > ---

Re: Possible use after free in fvwm3 [Re: sysutils/rofi sometimes coredumps in __vfprintf (+ similar crash in fvwm3)]

2023-09-30 Thread Thomas Adam
On Sat, 30 Sept 2023 at 11:32, Theo Buehler wrote: Hey all, > === > RCS file: patches/patch-fvwm_infostore_c > diff -N patches/patch-fvwm_infostore_c > --- /dev/null 1 Jan 1970 00:00:00 - > +++ patches/patch-fvwm_infostore_c

Possible use after free in fvwm3 [Re: sysutils/rofi sometimes coredumps in __vfprintf (+ similar crash in fvwm3)]

2023-09-30 Thread Theo Buehler
Cc: + Thomas Adam, Michael for fvwm3 expertise - jasper since this is no longer about rofi > > As a side note - yesterday I got very suspicious crash in fvwm3 > > during simple fvwm restart, I can't reproduce it, but the bt also had > > __vfprintf in it, fvwm3 dev's said that it was very strange

Re: sysutils/rofi sometimes coredumps in __vfprintf (+ similar crash in fvwm3)

2023-09-30 Thread Omar Polo
On 2023/09/28 22:10:08 +0300, Mikhail wrote: > Core was generated by `rofi'. > Program terminated with signal SIGSEGV, Segmentation fault. > #0 strlen () at /usr/src/lib/libc/arch/amd64/string/strlen.S:125 > 125 movq(%rax),%rdx /* get bytes to check */ > (gdb) bt > #0

sysutils/rofi sometimes coredumps in __vfprintf (+ similar crash in fvwm3)

2023-09-28 Thread Mikhail
[cc'ing maintainer] kern.version=OpenBSD 7.4 (GENERIC.MP) #1382: Wed Sep 27 10:51:31 MDT 2023 dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP $ rofi -show combi -modes combi -combi-modes "window,ssh,run" -terminal sterm $ rofi -show combi -modes combi -combi-modes "window