Re: remove useless if ${FLAVOR:Mpython3} from Makefile

2016-11-08 Thread Daniel Jakots
On Mon, 7 Nov 2016 11:40:10 +, Stuart Henderson wrote: > On 2016/11/07 07:13, Remi Pointel wrote: > > On 11/06/16 21:00, Daniel Jakots wrote: > > > > Sounds good for me except these 2 ports: Nice catch! Yes, I overlooked these. > > > Index: security/py-crypto/Makefile > > > ===

Re: remove useless if ${FLAVOR:Mpython3} from Makefile

2016-11-07 Thread Alexandr Shadchin
On Sun, Nov 06, 2016 at 09:00:51PM +0100, Daniel Jakots wrote: > Hi, > > In python.port.mk there is > .if ${MODPY_MAJOR_VERSION} == 2 > MODPY_BIN_SUFFIX = > .elif ${MODPY_MAJOR_VERSION} == 3 > MODPY_BIN_SUFFIX = -3 > .endif > > So guarding the rename in Makefile with if ${FLAVOR:Mpython3} is

Re: remove useless if ${FLAVOR:Mpython3} from Makefile

2016-11-07 Thread Stuart Henderson
On 2016/11/07 07:13, Remi Pointel wrote: > On 11/06/16 21:00, Daniel Jakots wrote: > > Hi, > > > > In python.port.mk there is > > .if ${MODPY_MAJOR_VERSION} == 2 > > MODPY_BIN_SUFFIX = > > .elif ${MODPY_MAJOR_VERSION} == 3 > > MODPY_BIN_SUFFIX = -3 > > .endif > > > > So guarding the rename i

Re: remove useless if ${FLAVOR:Mpython3} from Makefile

2016-11-06 Thread Remi Pointel
On 11/06/16 21:00, Daniel Jakots wrote: Hi, In python.port.mk there is .if ${MODPY_MAJOR_VERSION} == 2 MODPY_BIN_SUFFIX = .elif ${MODPY_MAJOR_VERSION} == 3 MODPY_BIN_SUFFIX = -3 .endif So guarding the rename in Makefile with if ${FLAVOR:Mpython3} is useless. And the day we'll switch to py3

remove useless if ${FLAVOR:Mpython3} from Makefile

2016-11-06 Thread Daniel Jakots
Hi, In python.port.mk there is .if ${MODPY_MAJOR_VERSION} == 2 MODPY_BIN_SUFFIX = .elif ${MODPY_MAJOR_VERSION} == 3 MODPY_BIN_SUFFIX = -3 .endif So guarding the rename in Makefile with if ${FLAVOR:Mpython3} is useless. And the day we'll switch to py3, having those if will even be a problem.