Re: plan9port buffer overflow

2016-05-23 Thread Ray Lai
Another buffer overflow found. To recap, libdraw/font.c has a hand-rolled realloc, which I replaced with reallocarray (until it is fixed upstream https://plan9port-review.googlesource.com/#/c/1520/). Then I found another overflow in 9term/win.c, caused by missing parentheses (for details see: http

Re: plan9port buffer overflow

2016-04-05 Thread Dmitrij D. Czarkoff
> Index: Makefile > === > RCS file: /home/cvs/ports/plan9/plan9port/Makefile,v > retrieving revision 1.13 > diff -u -p -u -p -r1.13 Makefile > --- Makefile 24 Jan 2016 01:07:19 - 1.13 > +++ Makefile 4 Apr 2016 19:28:12 -

Re: plan9port buffer overflow

2016-04-04 Thread Ray Lai
On Tue, 5 Apr 2016 04:41:22 +0800 Ray Lai wrote: > On 04/05/16 03:46, Ray Lai wrote: > > Acme keeps crashing because it essentially does a realloc but copies the > > new buffer's size from the smaller old buffer. > > Thunderbird seems to mangle the diff, second try. Third time's the charm: I

Re: plan9port buffer overflow

2016-04-04 Thread Ray Lai
On 04/05/16 03:46, Ray Lai wrote: Acme keeps crashing because it essentially does a realloc but copies the new buffer's size from the smaller old buffer. Thunderbird seems to mangle the diff, second try. Index: Makefile === RCS fi

plan9port buffer overflow

2016-04-04 Thread Ray Lai
Acme keeps crashing because it essentially does a realloc but copies the new buffer's size from the smaller old buffer. Index: Makefile === RCS file: /home/cvs/ports/plan9/plan9port/Makefile,v retrieving revision 1.13 diff -u -p -r1