Re: missing endbr64

2024-02-29 Thread Theo Buehler
On Thu, Feb 29, 2024 at 11:01:49AM +0100, Sebastian Reitenbach wrote: > On Wednesday, February 28, 2024 22:49 CET, Theo Buehler > wrote: > > > On Wed, Feb 28, 2024 at 10:44:27PM +0100, Sebastian Reitenbach wrote: > > > Hi, > > > On Wednesday, February 28, 2024 21:13 CET, Theo Buehler > > > wro

Re: missing endbr64

2024-02-29 Thread Sebastian Reitenbach
On Wednesday, February 28, 2024 22:49 CET, Theo Buehler wrote: > On Wed, Feb 28, 2024 at 10:44:27PM +0100, Sebastian Reitenbach wrote: > > Hi, > > On Wednesday, February 28, 2024 21:13 CET, Theo Buehler > > wrote: > > > > > On Sun, Feb 25, 2024 at 10:13:44PM +0100, Sebastian Reitenbach wrote:

Re: libdv: missing ENDBR64

2024-02-28 Thread Mark Kettenis
> Date: Wed, 28 Feb 2024 20:10:58 +0100 > From: Theo Buehler > > This is straightforward. There doesn't seem to be a possibility of > shortcuts via a macro, so just add endbr64 to the four functions in this > file. I could not find code that actually uses these, but it's probably > better to be s

Re: missing endbr64

2024-02-28 Thread Stuart Henderson
On 2024/02/28 22:49, Theo Buehler wrote: > PORTS_PRIVSEP should catch such things. (The CMakeLists file also has > a tls vs tsl typo) Plus pf.conf rules to block network access from _pbuild e.g. something along these lines (the first one is optional but helps with some tests that otherwise fail)

Re: missing endbr64

2024-02-28 Thread Theo Buehler
Mark Kettenis > > > wrote: > > > > > > > > x11/gnustep/libobjc2.log > > > > > ld: warning: __objc_block_trampoline_sret: missing endbr64 > > > > > ld: warning: __objc_block_trampoline: missing endbr64 > > > > > ld: warni

Re: libdv: missing ENDBR64

2024-02-28 Thread Stuart Henderson
On 2024/02/28 20:10, Theo Buehler wrote: > This is straightforward. There doesn't seem to be a possibility of > shortcuts via a macro, so just add endbr64 to the four functions in this > file. I could not find code that actually uses these, but it's probably > better to be safe than sorry. > > The

Re: missing endbr64

2024-02-28 Thread Sebastian Reitenbach
/libobjc2.log > > > > ld: warning: __objc_block_trampoline_sret: missing endbr64 > > > > ld: warning: __objc_block_trampoline: missing endbr64 > > > > ld: warning: objc_msgSend: missing endbr64 > > > > ld: warning: objc_msgSend_fpret: missing endbr64 > > > > ld: wa

Re: missing endbr64

2024-02-28 Thread Theo Buehler
On Sun, Feb 25, 2024 at 10:13:44PM +0100, Sebastian Reitenbach wrote: > On Sunday, February 25, 2024 16:44 CET, Mark Kettenis > wrote: > > > > x11/gnustep/libobjc2.log > > > ld: warning: __objc_block_trampoline_sret: missing endbr64 > > > ld: warning: __ob

libdv: missing ENDBR64

2024-02-28 Thread Theo Buehler
This is straightforward. There doesn't seem to be a possibility of shortcuts via a macro, so just add endbr64 to the four functions in this file. I could not find code that actually uses these, but it's probably better to be safe than sorry. The code is too old to have arm64 assembly. Index: Make

Re: missing endbr64

2024-02-27 Thread Mark Kettenis
ore that may need fixing. 119 ports total contained a warning. > > > I did not build the chromium variants. > > > > > > audio/deadbeef.log > > > ld: warning: ff_scalarproduct_and_madd_int16_sse2: missing endbr64 > > > > This is when building the plugin for pl

Re: missing endbr64

2024-02-27 Thread Stuart Henderson
m variants. > > > > audio/deadbeef.log > > ld: warning: ff_scalarproduct_and_madd_int16_sse2: missing endbr64 > > This is when building the plugin for playback of monkey's audio (ape) > files (plugins/ffap) which has its own copy of (a very old version of) > some asm

Re: missing endbr64

2024-02-27 Thread Stuart Henderson
ef.log > ld: warning: ff_scalarproduct_and_madd_int16_sse2: missing endbr64 This is when building the plugin for playback of monkey's audio (ape) files (plugins/ffap) which has its own copy of (a very old version of) some asm from ffmpeg, see plugins/ffap/x86inc.asm and dsputil_yasm.asm. This seems to do the trick on amd64,

Re: missing endbr64

2024-02-27 Thread Mark Kettenis
ll the libs (where this matters) get build early... > audio/deadbeef.log > ld: warning: ff_scalarproduct_and_madd_int16_sse2: missing endbr64 Another x86inc.asm case I think. > x11/afterstep.log > ld: warning: unw_getcontext: missing endbr64 That seems to be a problem with base.

Re: missing endbr64

2024-02-27 Thread Theo Buehler
Now that the bulk has completed here's the remainder of the list with two more that may need fixing. 119 ports total contained a warning. I did not build the chromium variants. audio/deadbeef.log ld: warning: ff_scalarproduct_and_madd_int16_sse2: missing endbr64 x11/afterstep.log ld: wa

Re: missing endbr64

2024-02-25 Thread Sebastian Reitenbach
On Sunday, February 25, 2024 16:44 CET, Mark Kettenis wrote: > > x11/gnustep/libobjc2.log > > ld: warning: __objc_block_trampoline_sret: missing endbr64 > > ld: warning: __objc_block_trampoline: missing endbr64 > > ld: warning: objc_msgSend: missing endbr64 > > l

Re: Add missing endbr64 to gstreamer1-plugins-good

2024-02-25 Thread Mark Kettenis
> Date: Sun, 25 Feb 2024 19:49:52 +0100 > From: Theo Buehler > > This fixes > > ld: warning: gst_yadif_filter_line_mode0_ssse3: missing endbr64 > ld: warning: gst_yadif_filter_line_mode2_ssse3: missing endbr64 > ld: warning: gst_yadif_filter_line_mode0_sse2: missi

Re: missing endbr64

2024-02-25 Thread Mark Kettenis
> Date: Sun, 25 Feb 2024 18:43:54 + > From: Stuart Henderson > > > > sysutils/borgbackup/2.0.log: lots of warnings about symbols from > > > openssl/3.1: > > > ld: warning: aesni_set_decrypt_key: missing endbr64 > > > ld: warning: aesni_set_e

Re: Add missing endbr64 to gstreamer1-plugins-good

2024-02-25 Thread Stuart Henderson
On 2024/02/25 19:49, Theo Buehler wrote: > This fixes > > ld: warning: gst_yadif_filter_line_mode0_ssse3: missing endbr64 > ld: warning: gst_yadif_filter_line_mode2_ssse3: missing endbr64 > ld: warning: gst_yadif_filter_line_mode0_sse2: missing endbr6

Re: missing endbr64

2024-02-25 Thread Stuart Henderson
On 2024/02/25 13:01, Stuart Henderson wrote: > On 2024/02/25 12:46, Stuart Henderson wrote: > > I will look at rspamd and luajit later today. > > > > lang/luajit.log > > > ld.lld: warning: lj_vm_unwind_c_eh: missing endbr64 > > > ld.lld: warning: lj_vm_unwin

Add missing endbr64 to gstreamer1-plugins-good

2024-02-25 Thread Theo Buehler
This fixes ld: warning: gst_yadif_filter_line_mode0_ssse3: missing endbr64 ld: warning: gst_yadif_filter_line_mode2_ssse3: missing endbr64 ld: warning: gst_yadif_filter_line_mode0_sse2: missing endbr64 ld: warning: gst_yadif_filter_line_mode2_sse2: missing endbr64 These are generated by the two

Re: missing endbr64

2024-02-25 Thread Stuart Henderson
> > sysutils/borgbackup/2.0.log: lots of warnings about symbols from > > openssl/3.1: > > ld: warning: aesni_set_decrypt_key: missing endbr64 > > ld: warning: aesni_set_encrypt_key: missing endbr64 > > ld: warning: ChaCha20_ctr32: missing endbr64 > > ld: w

Re: missing endbr64

2024-02-25 Thread Mark Kettenis
suspect NOBTCFI > is missing. Go, Haskell and Ocaml ports are linked using nobtcfi, as far > as I know, so I moved them to the end without details. > > devel/ffcall.log > ld: warning: __vacall_r: missing endbr64 This one is deliberately not addressed; see my commit to that port.

Re: missing endbr64

2024-02-25 Thread Brian Callahan
On 2/25/2024 4:39 AM, Theo Buehler wrote > D > Missing NOBTCFI for some of these? > > devel/dtools.log > devel/dub,dmd.log > lang/dmd.log > lang/ldc.log > sysutils/trash-d.log > Yes, the D ports should have NOBTCFI. I am working on this, but it is not yet ready for prime time. Thanks. ~Brian

Re: missing endbr64

2024-02-25 Thread Theo Buehler
a/x264.log > > ld: warning: x264_8_sub8x8_dct_sse2.skip_prologue: missing endbr64 > > ld: warning: x264_8_sub8x8_dct8_sse2.skip_prologue: missing endbr64 > > ld: warning: x264_8_sub8x8_dct_ssse3.skip_prologue: missing endbr64 > > ld: warning: x264_8_sub8x8_dct8_ssse3.skip_prolo

Re: missing endbr64

2024-02-25 Thread Stuart Henderson
On 2024/02/25 12:46, Stuart Henderson wrote: > I will look at rspamd and luajit later today. > > lang/luajit.log > > ld.lld: warning: lj_vm_unwind_c_eh: missing endbr64 > > ld.lld: warning: lj_vm_unwind_rethrow: missing endbr64 > > ld.lld: warning: lj_vm_unwind_ff_eh:

Re: missing endbr64

2024-02-25 Thread Stuart Henderson
g D where I suspect NOBTCFI > is missing. Go, Haskell and Ocaml ports are linked using nobtcfi, as far > as I know, so I moved them to the end without details. > > devel/ffcall.log > ld: warning: __vacall_r: missing endbr64 > > devel/valgrind.log > ld: warning: __start

Re: missing endbr64

2024-02-25 Thread Mark Kettenis
suspect NOBTCFI > is missing. Go, Haskell and Ocaml ports are linked using nobtcfi, as far > as I know, so I moved them to the end without details. ... > multimedia/x264.log > ld: warning: x264_8_sub8x8_dct_sse2.skip_prologue: missing endbr64 > ld: warning: x264_8_sub8x8_dct8_sse2.s

missing endbr64

2024-02-25 Thread Theo Buehler
I know, so I moved them to the end without details. devel/ffcall.log ld: warning: __vacall_r: missing endbr64 devel/valgrind.log ld: warning: __start: missing endbr64 lang/gcc/11,-ada.log lang/gcc/8.log: ld.lld: warning: pow2_or_zerop(unsigned long long): missing endbr64 ld.lld: warning: pow2p_hw

Re: openssl/3.1: missing endbr64 in bsaes_xts

2024-02-24 Thread Mark Kettenis
> Date: Sat, 24 Feb 2024 17:59:55 +0100 > From: Theo Buehler > > Two more endbr64 were missed in 3.1. I'll sync the diff to quictls. These are indeed assigned to function pointers in crypto/evp/e_aes.c ok kettenis@ > Index: Makefile > ===

openssl/3.1: missing endbr64 in bsaes_xts

2024-02-24 Thread Theo Buehler
Two more endbr64 were missed in 3.1. I'll sync the diff to quictls. Index: Makefile === RCS file: /cvs/ports/security/openssl/3.1/Makefile,v diff -u -p -r1.21 Makefile --- Makefile22 Feb 2024 13:47:11 - 1.21 +++ Makefile

Re: openssl/1.1: missing endbr64 for padlock engine

2024-02-24 Thread Theo Buehler
On Sat, Feb 24, 2024 at 05:39:23PM +0100, Mark Kettenis wrote: > > Date: Sat, 24 Feb 2024 17:33:10 +0100 > > From: Theo Buehler > > > > This adds missing endbr64 to the padlock engine in openssl/1.1: > > > > ld: warning: padlock_capability: missing endbr6

Re: openssl/1.1: missing endbr64 for padlock engine

2024-02-24 Thread Mark Kettenis
> Date: Sat, 24 Feb 2024 17:33:10 +0100 > From: Theo Buehler > > This adds missing endbr64 to the padlock engine in openssl/1.1: > > ld: warning: padlock_capability: missing endbr64 > ld: warning: padlock_key_bswap: missing endbr64 > ld: warning: padlock_verify_conte

openssl/1.1: missing endbr64 for padlock engine

2024-02-24 Thread Theo Buehler
This adds missing endbr64 to the padlock engine in openssl/1.1: ld: warning: padlock_capability: missing endbr64 ld: warning: padlock_key_bswap: missing endbr64 ld: warning: padlock_verify_context: missing endbr64 ld: warning: padlock_reload_key: missing endbr64 ld: warning: padlock_aes_block