Re: fix nodejs/node-gyp tarball version

2020-04-02 Thread Denis Fondras
On Thu, Apr 02, 2020 at 09:05:01AM -0600, Aaron Bieber wrote: > On Thu, 02 Apr 2020 at 15:54:03 +0200, Jeremie Courreges-Anglas wrote: > > > > +cc maintainer ;) > > > > On Thu, Apr 02 2020, Denis Fondras wrote: > > > node-gyp needs to know about the installed Node.js version. > > > > > > This ne

Re: fix nodejs/node-gyp tarball version

2020-04-02 Thread Aaron Bieber
On Thu, 02 Apr 2020 at 15:54:03 +0200, Jeremie Courreges-Anglas wrote: > > +cc maintainer ;) > > On Thu, Apr 02 2020, Denis Fondras wrote: > > node-gyp needs to know about the installed Node.js version. > > > > This needs to be updated each time Node.js is upgraded. May we do this > > automatica

Re: fix nodejs/node-gyp tarball version

2020-04-02 Thread Jeremie Courreges-Anglas
+cc maintainer ;) On Thu, Apr 02 2020, Denis Fondras wrote: > node-gyp needs to know about the installed Node.js version. > > This needs to be updated each time Node.js is upgraded. May we do this > automatically with sed in Makefile pre-patch section ? pre-configure already uses ${SUBST_CMD}

fix nodejs/node-gyp tarball version

2020-04-02 Thread Denis Fondras
node-gyp needs to know about the installed Node.js version. This needs to be updated each time Node.js is upgraded. May we do this automatically with sed in Makefile pre-patch section ? Index: patches/patch-deps_npm_node_modules_node-gyp_lib_install_js