Re: devel/gettext: get rid of -lintl stpcpy warning

2012-07-13 Thread Peter
>On 2012/07/13 02:37, Peter Laufenberg wrote: >> >I'd just like to point out on-list that we shouldn't be patching >> >away stpcpy everywhere, it is easy to introduce a bug in perfectly >> >correct code by doing this (as happened in some cases with strlcpy >> >patches in the ports tree), it's just

Re: devel/gettext: get rid of -lintl stpcpy warning

2012-07-13 Thread Stuart Henderson
On 2012/07/13 02:37, Peter Laufenberg wrote: > >I'd just like to point out on-list that we shouldn't be patching > >away stpcpy everywhere, it is easy to introduce a bug in perfectly > >correct code by doing this (as happened in some cases with strlcpy > >patches in the ports tree), it's just that

Re: devel/gettext: get rid of -lintl stpcpy warning

2012-07-12 Thread Peter Laufenberg
>I'd just like to point out on-list that we shouldn't be patching >away stpcpy everywhere, it is easy to introduce a bug in perfectly >correct code by doing this (as happened in some cases with strlcpy >patches in the ports tree), it's just that gettext is *very* commonly >used and the linker warni

Re: devel/gettext: get rid of -lintl stpcpy warning

2012-07-12 Thread Stuart Henderson
This looks good. I'd just like to point out on-list that we shouldn't be patching away stpcpy everywhere, it is easy to introduce a bug in perfectly correct code by doing this (as happened in some cases with strlcpy patches in the ports tree), it's just that gettext is *very* commonly used and the

devel/gettext: get rid of -lintl stpcpy warning

2012-07-10 Thread Christian Weisgerber
The goal here is to get rid of these warnings that fill our build logs: /usr/local/lib/libintl.so.6.0: warning: stpcpy() is dangerous GNU crap; don't use it Note that this is only about libintl proper, not about the msg* tools and their helper libraries. These patches need reviewing. I'm not c