Re: boost warning fix

2011-03-31 Thread Marco Peereboom
The warning should be that you are using boost ;-) On Tue, Mar 29, 2011 at 04:15:50PM +0100, Federico G. Schwindt wrote: > > Hi, > > This fixes the warning when -Wnon-virtual-dtor is used, which is quite > annoying and might hide other crap. > Shouldn't break anything TBH but worth checkin

Re: boost warning fix

2011-03-31 Thread Landry Breuil
On Tue, Mar 29, 2011 at 04:15:50PM +0100, Federico G. Schwindt wrote: > > Hi, > > This fixes the warning when -Wnon-virtual-dtor is used, which is quite > annoying and might hide other crap. > Shouldn't break anything TBH but worth checking in a bulk. Fwiw, no fallout in a bulk.

Re: boost warning fix

2011-03-29 Thread Matthew Dempsky
On Tue, Mar 29, 2011 at 8:15 AM, Federico G. Schwindt wrote: >  Comments? Any OKs? I think this changes the ABI, so you should probably bump the soname if you're going to commit this. However, it seems like a deliberate decision on their part to omit the virtual tag here (not familiar with conte

Re: boost warning fix

2011-03-29 Thread Federico G. Schwindt
On Tue, Mar 29, 2011 at 09:53:39AM -0700, Matthew Dempsky wrote: > On Tue, Mar 29, 2011 at 8:15 AM, Federico G. Schwindt > wrote: > > ?Comments? Any OKs? > > I think this changes the ABI, so you should probably bump the soname > if you're going to commit this. true. > However, it seems like

boost warning fix

2011-03-29 Thread Federico G. Schwindt
Hi, This fixes the warning when -Wnon-virtual-dtor is used, which is quite annoying and might hide other crap. Shouldn't break anything TBH but worth checking in a bulk. Comments? Any OKs? f.- Index: Makefile === RCS file