Re: UPDATE: rdesktop 1.6.0

2008-08-07 Thread Marc Peters
> On Sat, Jun 21, 2008 at 11:03:49AM +0200, Steven Mestdagh wrote: > > > Giovanni Bechis [2008-06-18, 12:53:39]: > >> > > It works well @i386, PLIST updated and PKGNAME removed. > > > > > > seems to work on amd64 too. > > > > > > however, it picks up libsamplerate if it's installed. others > report

Re: UPDATE: rdesktop 1.6.0

2008-08-05 Thread Brad
On Tuesday 05 August 2008 08:08:30 Jasper Lievisse Adriaanse wrote: > - specify license marker It should be GPLv2+. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

Re: UPDATE: rdesktop 1.6.0

2008-08-05 Thread Jasper Lievisse Adriaanse
On Sat, Jun 21, 2008 at 11:03:49AM +0200, Steven Mestdagh wrote: > Giovanni Bechis [2008-06-18, 12:53:39]: > > It works well @i386, PLIST updated and PKGNAME removed. > > seems to work on amd64 too. > > however, it picks up libsamplerate if it's installed. others reported that > it does not make

Re: UPDATE: rdesktop 1.6.0

2008-06-21 Thread Steven Mestdagh
Giovanni Bechis [2008-06-18, 12:53:39]: > It works well @i386, PLIST updated and PKGNAME removed. seems to work on amd64 too. however, it picks up libsamplerate if it's installed. others reported that it does not make a difference, so maybe the configure script needs some tweaking to avoid pickin

Re: UPDATE: rdesktop 1.6.0

2008-06-20 Thread Giovanni Bechis
Matthew Clarke wrote: You might want to add libsamplerate (audio/libsamplerate) to the port's dependencies, as that library will be found and used if it is installed. I could't tell that the presence of libsamplerate made any difference to the few sounds that I've heard during testing so far, tho

Re: UPDATE: rdesktop 1.6.0

2008-06-19 Thread Stuart Henderson
On 2008/06/19 10:25, Matthew Clarke wrote: > Wed, Jun 18, 2008 at 12:53:39PM +0200, Giovanni Bechis may have written: > > > It works well @i386, PLIST updated and PKGNAME removed. > > Cheers > > Giovanni > > [ snip patch ] > > Works well on i386 here. > > - connect to XP Pro on laptop

Re: UPDATE: rdesktop 1.6.0

2008-06-19 Thread Matthew Clarke
Wed, Jun 18, 2008 at 12:53:39PM +0200, Giovanni Bechis may have written: > It works well @i386, PLIST updated and PKGNAME removed. > Cheers > Giovanni [ snip patch ] Works well on i386 here. - connect to XP Pro on laptop at 1024x768 - connect to XP Pro on other laptop at 1680

Re: Comments in patches (was: UPDATE: rdesktop 1.6.0)

2008-06-18 Thread Antoine Jacoutot
On Wed, 18 Jun 2008, Matthias Kilian wrote: > If the purpose of a patch is obvious, there's no reason to add a > comment. But sometimes it isn't obvious, or you're patching stuff > you want to send to (and explain to) upstream later. For an example > of missing comments, please look at the ghostscr

Comments in patches (was: UPDATE: rdesktop 1.6.0)

2008-06-18 Thread Matthias Kilian
On Tue, Jun 17, 2008 at 08:15:09PM -0500, Will Maier wrote: > We don't usually include comments in the patch files. To second Bernd's response: If the purpose of a patch is obvious, there's no reason to add a comment. But sometimes it isn't obvious, or you're patching stuff you want to send to (a

Re: UPDATE: rdesktop 1.6.0

2008-06-18 Thread Giovanni Bechis
It works well @i386, PLIST updated and PKGNAME removed. Cheers Giovanni Index: Makefile === RCS file: /cvs/ports/x11/rdesktop/Makefile,v retrieving revision 1.25 diff -u -p -r1.25 Makefile --- Makefile15 Sep 2007 20:04:24 -

Re: UPDATE: rdesktop 1.6.0

2008-06-17 Thread Bernd Ahlers
Will Maier [Tue, Jun 17, 2008 at 08:15:09PM -0500] wrote: >> Index: patches/patch-rdpsnd_sun_c >> === >> RCS file: patches/patch-rdpsnd_sun_c >> diff -N patches/patch-rdpsnd_sun_c >> --- /dev/null1 Jan 1970 00:00:00 - >> ++

Re: UPDATE: rdesktop 1.6.0

2008-06-17 Thread Chris Kuethe
On Mon, Jun 16, 2008 at 10:45 AM, Devin Smith <[EMAIL PROTECTED]> wrote: > 1. I wasn't sure if PKGNAME should have the p0 appended or should it just > be ${DISTNAME}. PKGNAME can be unset, thereby reverting to DISTNAME. This is a new version of the port, with no local patchlevel. > 2. When addi

Re: UPDATE: rdesktop 1.6.0

2008-06-17 Thread Will Maier
Hi Devin- On Mon, Jun 16, 2008 at 10:45:23AM -0700, Devin Smith wrote: > Some questions I had: > > 1. I wasn't sure if PKGNAME should have the p0 appended or should it just >be ${DISTNAME}. The pN suffix is the port patchlevel; if you're bumping the upstream version, you don't need it. Since

UPDATE: rdesktop 1.6.0

2008-06-17 Thread Devin Smith
Here's an update for rdesktop from 1.5.0 to 1.6.0. Here are the changes from 1.5.0 to 1.6.0: Key changes: * Fix for potential vulnerability against compromised/malicious servers (reported by iDefense) * Fix for crash with recent versions of X.Org * Fix for connection to Windows 2008 Server * A