Re: update net/rsync 3.2.4

2022-05-16 Thread Nam Nguyen
Nam Nguyen writes: > Nam Nguyen writes: > >> Two diffs are attached, incorporating feedback from espie@ sthen@ and >> naddy@. Feedback is welcome. OK? ping. Diffs are reattached for convenience. >> >> 1. rsync_stable.diff: intended for -stable. brings bundled zlib from >>rsync 3.2.4 to 3.2.3

Re: update net/rsync 3.2.4

2022-04-26 Thread Nam Nguyen
Nam Nguyen writes: > Two diffs are attached, incorporating feedback from espie@ sthen@ and > naddy@. Feedback is welcome. OK? > > 1. rsync_stable.diff: intended for -stable. brings bundled zlib from >rsync 3.2.4 to 3.2.3 with this commit: > > https://github.com/WayneD/rsync/commit/1de71e8a

Re: update net/rsync 3.2.4

2022-04-26 Thread Christian Weisgerber
Nam Nguyen: > 2. rsync.diff: > - --enable-md5-asm (from naddy@ to retain > checking whether to enable MD5 ASM optimizations... yes (x86_64)) Unfortunately, this breaks on !amd64: checking whether to enable MD5 ASM optimizations... unavailable configure.sh: error: The ASM optimizations ar

Re: update net/rsync 3.2.4

2022-04-26 Thread Stuart Henderson
On 2022/04/25 20:41, Nam Nguyen wrote: > - install rrsync(1) man page. If --with-rrsync is used to build and > install the man page, it introduces python3 as a dependency to run > ${WRKSRC}/md-convert script. Drawback: rrsync(1) prints 3.2.4pre4 a build-only dependency on python is not a probl

Re: update net/rsync 3.2.4

2022-04-25 Thread Nam Nguyen
Two diffs are attached, incorporating feedback from espie@ sthen@ and naddy@. Feedback is welcome. OK? 1. rsync_stable.diff: intended for -stable. brings bundled zlib from rsync 3.2.4 to 3.2.3 with this commit: https://github.com/WayneD/rsync/commit/1de71e8a7870fa1be29f562df61f4c5c4685818f

Re: update net/rsync 3.2.4

2022-04-25 Thread Christian Weisgerber
Christian Weisgerber: > * We should try --enable-roll-simd --enable-roll-asm for the > checksum asm. I checked, and it doesn't work: --enable-roll-simd adds intrinsics-based C++ code for SSE2 and SSSE3; --enable-roll-asm then adds assembly code for AVX2 on top of it. > In 3.2.3, the configur

Re: update net/rsync 3.2.4

2022-04-25 Thread Christian Weisgerber
Nam Nguyen: > Here is an update for net/rsync 3.2.4 based on tj@'s diff which does the > following: > - move to system zlib instead of bundled zlib This requires an explanation. I seem to remember that rsync's bundled zlib is modified and the bitstream it produces is incompatible with standard zl

Re: update net/rsync 3.2.4

2022-04-21 Thread Stuart Henderson
On 2022/04/20 16:11, Nam Nguyen wrote: > Here is an update for net/rsync 3.2.4 based on tj@'s diff which does the > following: > - move to system zlib instead of bundled zlib There was a reason for using the bundled zlib, but I think that the way compression negotiation now works, it should be fai