On Mon, October 22, 2018 10:26, Jeremie Courreges-Anglas wrote:
> On Sun, Oct 21 2018, Thomas Frohwein wrote:
>> Hi,
>>
>> George Koehler ( kernigh () gmail DOT com ) reports that all devel/sdl2
>> crash
>> on init on macppc. The reason seems to be an inappropriate bool type. The
>> patch
>> below
On Mon, Oct 22, 2018 at 06:12:00PM -, Christian Weisgerber wrote:
> On 2018-10-22, Marc Espie wrote:
>
> > There are some technical reasons to put a space before the =, because
> > it DOES let things be unambiguous for make.
> >
> > (say, if S=-c++, PKGNAME${S}=somevalue will NOT do what yo
On Mon, Oct 22, 2018 at 06:12:00PM -, Christian Weisgerber wrote:
> On 2018-10-22, Marc Espie wrote:
>
> > There are some technical reasons to put a space before the =, because
> > it DOES let things be unambiguous for make.
> >
> > (say, if S=-c++, PKGNAME${S}=somevalue will NOT do what yo
On 2018-10-22, Marc Espie wrote:
> There are some technical reasons to put a space before the =, because
> it DOES let things be unambiguous for make.
>
> (say, if S=-c++, PKGNAME${S}=somevalue will NOT do what you expect)
That construct is exceedingly rare in port Makefiles.
In fact, I can't
On Sun, October 21, 2018 21:39, Thomas Frohwein wrote:
> Hi,
>
> George Koehler ( kernigh () gmail DOT com ) reports that all devel/sdl2 crash
> on init on macppc. The reason seems to be an inappropriate bool type. The
> patch
> below for SDL_x11keyboard.c fixes the issue according to George. This
On Mon, Oct 22, 2018 at 01:43:32PM +0200, Jeremie Courreges-Anglas wrote:
> Still, I don't like people completely changing the whitespace in
> a Makefile while also introducing semantic changes in the same commit.
> It makes diffs and cvs history hard to review, which is BAD. :)
Yep, that's unnee
On Mon, Oct 22 2018, Marc Espie wrote:
> On Mon, Oct 22, 2018 at 09:26:21AM +0200, Jeremie Courreges-Anglas wrote:
>> Some people prefer no space before '=' and afaik no consensus has been
>> reached. The formatting in this port is consistent, so please avoid
>> needless churn unless you really c
On Mon, Oct 22, 2018 at 09:26:21AM +0200, Jeremie Courreges-Anglas wrote:
> Some people prefer no space before '=' and afaik no consensus has been
> reached. The formatting in this port is consistent, so please avoid
> needless churn unless you really can't stand the current Makefile. ;)
There a
On Sun, Oct 21 2018, Thomas Frohwein wrote:
> Hi,
>
> George Koehler ( kernigh () gmail DOT com ) reports that all devel/sdl2 crash
> on init on macppc. The reason seems to be an inappropriate bool type. The
> patch
> below for SDL_x11keyboard.c fixes the issue according to George. This has been
