Re: Add devel/rust-analyzer

2024-01-19 Thread Sebastien Marie
Edd Barrett writes: > Hi, > >> I am unsure to properly understand here. You need rust,-src and rustfmt >> to build the port now ? > > You're right, that's bogus. Fixed. > >> post-build: >> cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${LOCALBASE}/bin/asciidoctor \ >> docs/user/manual.a

Re: Add devel/rust-analyzer

2024-01-19 Thread Edd Barrett
Hi, > I am unsure to properly understand here. You need rust,-src and rustfmt > to build the port now ? You're right, that's bogus. Fixed. > post-build: > cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${LOCALBASE}/bin/asciidoctor \ > docs/user/manual.adoc Fixed, and using -safe. >

Re: Add devel/rust-analyzer

2024-01-19 Thread Sebastien Marie
Edd Barrett writes: > About the latter, the tests expect "stable" to appear in the output of > `rustfmt > --version`. But that's not so for our package: > > ``` > $ rustfmt --version > rustfmt 1.7.0- > ``` > > I suspect it should return `rustfmt 1.7.0-stable`? CC semarie@ I will take a look

Re: Add devel/rust-analyzer

2024-01-19 Thread Edd Barrett
Hi, On Thu, Jan 18, 2024 at 09:44:20AM -, Laurent Cheylus wrote: > - Add MAKE_ENV += CFG_RELEASE=${GH_TAGNAME} to set version > - Add post-build to generate HTML doc with asciidoctor > - Install binary and doc in do-install Thanks! I've looked at Laurent's openbsd-wip port and incorporated t

Re: Add devel/rust-analyzer

2024-01-18 Thread Edd Barrett
On Thu, Jan 18, 2024 at 09:44:20AM -, Laurent Cheylus wrote: > The RDEP on lang/rust,-src is not optional, rust-analyzer tool needs Rust > sources to work properly. Agreed, but on the other hand, you may not be using the packaged version of Rust, in which case you'd point RUST_SRC_PATH elsewh

Re: Add devel/rust-analyzer

2024-01-17 Thread Sebastien Marie
Theo Buehler writes: > > And as semarie pointed out crates.inc should be regenerated to include > the licenses (make modcargo-gen-crates-licenses) > a few more comments. - license is dual Apache 2.0 / MIT - SEPARATE_BUILD=Yes is supported - MODCARGO_RUSTFLAGS setting seems unnecessary (it buil

Re: Add devel/rust-analyzer

2024-01-17 Thread Theo Buehler
On Wed, Jan 17, 2024 at 03:32:01PM +0100, Theo Buehler wrote: > On Tue, Dec 19, 2023 at 12:14:20PM +0100, Benjamin Stürz wrote: > > On 12/4/23 02:22, Greg Steuck wrote: > > > Greg Steuck writes: > > > > > > > I verified that this works well enough in emacs with eglot. Maybe others > > > > will fi

Re: Add devel/rust-analyzer

2024-01-17 Thread Theo Buehler
On Tue, Dec 19, 2023 at 12:14:20PM +0100, Benjamin Stürz wrote: > On 12/4/23 02:22, Greg Steuck wrote: > > Greg Steuck writes: > > > > > I verified that this works well enough in emacs with eglot. Maybe others > > > will find it useful enough to OK? If so, I'd apprecite a bit of extra > > > dilig

Re: Add devel/rust-analyzer

2023-12-19 Thread Benjamin Stürz
On 12/4/23 02:22, Greg Steuck wrote: Greg Steuck writes: I verified that this works well enough in emacs with eglot. Maybe others will find it useful enough to OK? If so, I'd apprecite a bit of extra diligence as this is my first rust port. rust-src seems important for this port, maybe it sho

Re: Add devel/rust-analyzer

2023-12-03 Thread Benjamin Stürz
On 04.12.23 02:22, Greg Steuck wrote: Greg Steuck writes: I verified that this works well enough in emacs with eglot. Maybe others will find it useful enough to OK? If so, I'd apprecite a bit of extra diligence as this is my first rust port. It works for me. rust-src seems important for thi

Re: Add devel/rust-analyzer

2023-12-03 Thread Greg Steuck
Greg Steuck writes: > I verified that this works well enough in emacs with eglot. Maybe others > will find it useful enough to OK? If so, I'd apprecite a bit of extra > diligence as this is my first rust port. > > rust-src seems important for this port, maybe it should be in RUN_DEPENDS? As remi