Re: FindIconv.cmake

2020-04-09 Thread Rafael Sadowski
On Thu Apr 09, 2020 at 09:43:32AM +0100, Stuart Henderson wrote: > Please no big changes to cmake before 6.7 :-) > Of course, post 6.7.

Re: FindIconv.cmake

2020-04-09 Thread Stuart Henderson
FindIconv.cmake? This can cause problems because this it misses the 'IMPORTED target' provided by cmake's original version of FindIconv.cmake, see: https://cmake.org/cmake/help/v3.16/module/FindIconv.html I guess the attached diff does not break anything, but I can't tell for sure.. Tha

Re: FindIconv.cmake

2020-04-08 Thread Rafael Sadowski
On Tue Mar 31, 2020 at 07:27:42PM +0200, Raphael Graf wrote: > Is it intentional that the cmake port still installs a custom version of > FindIconv.cmake? > This can cause problems because this it misses the 'IMPORTED target' provided > by cmake's original version of Fi

FindIconv.cmake

2020-03-31 Thread Raphael Graf
Is it intentional that the cmake port still installs a custom version of FindIconv.cmake? This can cause problems because this it misses the 'IMPORTED target' provided by cmake's original version of FindIconv.cmake, see: https://cmake.org/cmake/help/v3.16/module/FindIconv.ht