Re: [patch] Test target PATH

2015-09-01 Thread Marc Espie
I have to agree with Stuart there. Changing stuff in there might cause problems down the road. Also note that stuff like the install-wrapper might get picked up by configure and such... so changing the PATH in a single port is not enough in general. I think an actual fix would involve making the

Re: [patch] Test target PATH

2015-08-28 Thread Matthew Martin
On Fri, Aug 28, 2015 at 08:47:05PM +0100, Stuart Henderson wrote: > On 2015/08/27 22:04, Matthew Martin wrote: > > ${WRKDIR}/bin is only in PATH during extract, configure, build, fake, > > and test. Since fake creates the chown and chgrp symlinks, extract, > > configure, build, and test must not de

Re: [patch] Test target PATH

2015-08-28 Thread Stuart Henderson
On 2015/08/27 22:04, Matthew Martin wrote: > ${WRKDIR}/bin is only in PATH during extract, configure, build, fake, > and test. Since fake creates the chown and chgrp symlinks, extract, > configure, build, and test must not depend on those symlinks as they > don't depend on fake. Would it be accepta

Re: [patch] Test target PATH

2015-08-28 Thread Matthew Martin
On Thu, Aug 27, 2015 at 11:27:44PM -0400, Raul Miller wrote: > On Thu, Aug 27, 2015 at 11:04 PM, Matthew Martin wrote: > > On Thu, Aug 27, 2015 at 11:47:19PM +0200, Juan Francisco Cantero Hurtado > > wrote: > >> >---rm -f ${WRKDIR}/bin/chgrp > > > > While this would fix the problem, since the

Re: [patch] Test target PATH

2015-08-27 Thread Raul Miller
On Thu, Aug 27, 2015 at 11:04 PM, Matthew Martin wrote: > On Thu, Aug 27, 2015 at 11:47:19PM +0200, Juan Francisco Cantero Hurtado > wrote: >> >---rm -f ${WRKDIR}/bin/chgrp > > While this would fix the problem, since the problem is not in zsh > itself, I don't think that the zsh port is the r

Re: [patch] Test target PATH

2015-08-27 Thread Matthew Martin
On Thu, Aug 27, 2015 at 11:47:19PM +0200, Juan Francisco Cantero Hurtado wrote: > I see the problem now. You can remove the symlinks from ${WRKDIR}/bin with: > > pre-test: > >---rm -f ${WRKDIR}/bin/chgrp While this would fix the problem, since the problem is not in zsh itself, I don't think t

Re: [patch] Test target PATH

2015-08-27 Thread Juan Francisco Cantero Hurtado
I see the problem now. You can remove the symlinks from ${WRKDIR}/bin with: pre-test: >---rm -f ${WRKDIR}/bin/chgrp The problem with your patch is that you're modifying the environment for thousands of ports and we can't test manually every port to see if your changes are breaking something.

Re: [patch] Test target PATH

2015-08-27 Thread Matthew Martin
On Thu, Aug 27, 2015 at 11:50:19AM +0200, Juan Francisco Cantero Hurtado wrote: > Can you try this in your port? > > TEST_ENV="PATH=${PATH}:YOURPATH" or TEST_ENV="PATH=YOURPATH:${PATH}" I don't think you're following the problem. It's not that anything needs to be added to PATH; it's that the fir

Re: [patch] Test target PATH

2015-08-27 Thread Juan Francisco Cantero Hurtado
Can you try this in your port? TEST_ENV="PATH=${PATH}:YOURPATH" or TEST_ENV="PATH=YOURPATH:${PATH}" On Thu, Aug 27, 2015 at 12:37:22AM -0500, Matthew Martin wrote: > The zsh port fails an additional test when invoked with make clean fake > test instead of make clean test. This is because in its t

[patch] Test target PATH

2015-08-26 Thread Matthew Martin
The zsh port fails an additional test when invoked with make clean fake test instead of make clean test. This is because in its tests it touch zerolength chgrp $EGID zerolength and then tests that zerolength has a group of EGID. Since make fake puts a symlink in ${WRKDIR}/bin from chgrp to /b