Looks ok at a glance.
I haven't tested/checked to see that the desired/correct tclsh is being used.
Nitpick:
I usually put MODTCL_VERSION immediately after MODULES.
Seems that Makefile.template suggests this as well.
Stu
On Tuesday, March 25, 2025 at 03:14:35 p.m. EDT, Volker Schlecht
wrote:
On 2025-03-25 18:41, Stuart Cassoff wrote:
MODTCL_VERSION=8.6
Would be preferable.
Also, in the diff, autosetup_tclsh={MODTCL_BIN} is missing the $.
Whoops :-)
How about the attached diff then?
Index: Makefile
===
RCS file: /cv
A bit late to the party...
On Sunday, March 2, 2025 at 11:47:13 a.m. EST, Jeremie Courreges-Anglas
wrote:
The "./jimsh0" case above is actually the executable name of a
stripped version of jimtcl shipped as autosetup/jimsh0.c in the sqlite
tarball. The first other tclsh executable in the lis
I'm ok with either --enable-all or the individual flags.
On 2025/03/02 22:02, Jeremie Courreges-Anglas wrote:
> On Sun, Mar 02, 2025 at 09:36:24PM +0100, Volker Schlecht wrote:
> > On 2025-03-02 17:47, Jeremie Courreges-Anglas wrote:
> > > Confirmed. I checked that the same -D/#defines set was u
On Sun, Mar 02, 2025 at 09:36:24PM +0100, Volker Schlecht wrote:
> On 2025-03-02 17:47, Jeremie Courreges-Anglas wrote:
> > Confirmed. I checked that the same -D/#defines set was used before
> > and after. In the new version some are passed on the cli and some end
> > up in sqlite_cfg.h. Looks m
On 2025-03-02 17:47, Jeremie Courreges-Anglas wrote:
Confirmed. I checked that the same -D/#defines set was used before
and after. In the new version some are passed on the cli and some end
up in sqlite_cfg.h. Looks mostly good, fts3 is indeed implied by
fts4, but geopoly is no longer implied
On Sun, Mar 02, 2025 at 05:47:02PM +0100, Jeremie Courreges-Anglas wrote:
>
> FWIW I put your last diff in a bulk build on arm64 (clang 19), looks
> mostly good so far:
>
> I=10372 B=144 Q=3229 T=596 F=0 !=263
> L=net/icinga/core2
> E=games/zelda3-ro
>
> More input below,
>
> On Fri, Feb 28, 20
On Sun, Mar 02, 2025 at 05:47:02PM +0100, Jeremie Courreges-Anglas wrote:
> Confirmed. I checked that the same -D/#defines set was used before
> and after. In the new version some are passed on the cli and some end
> up in sqlite_cfg.h.
Just to be 100% clear: I'm not saying that the exact same
FWIW I put your last diff in a bulk build on arm64 (clang 19), looks
mostly good so far:
I=10372 B=144 Q=3229 T=596 F=0 !=263
L=net/icinga/core2
E=games/zelda3-ro
More input below,
On Fri, Feb 28, 2025 at 07:11:13PM +0100, Volker Schlecht wrote:
> Alright, so here goes my next attempt, addressi
On Thu, Feb 27, 2025 at 08:07:40PM +0100, Volker Schlecht wrote:
> On 2025-02-27 18:43, Stuart Henderson wrote:
> > two things definitely need changing:
> >
> > - two symbols were removed; -DSQLITE_ENABLE_RTREE brings them back
>
> Right, so does --enable-rtree - would that be ok as well?
>
> >
Le Fri, Feb 28, 2025 at 07:11:13PM +0100, Volker Schlecht a écrit :
> Alright, so here goes my next attempt, addressing
>
> On 2025-02-28 18:11, Jeremie Courreges-Anglas wrote:
> [...]
> > I'd rather patch out the hidden dep so that the build is
> > deterministic, even on a machine where jimtcl is
Alright, so here goes my next attempt, addressing
On 2025-02-28 18:11, Jeremie Courreges-Anglas wrote:
[...]
I'd rather patch out the hidden dep so that the build is
deterministic, even on a machine where jimtcl is already installed.
I know you're not responsible for the current situation, bu
On 2025/02/28 18:11, Jeremie Courreges-Anglas wrote:
> On Thu, Feb 27, 2025 at 08:07:40PM +0100, Volker Schlecht wrote:
> > On 2025-02-27 18:43, Stuart Henderson wrote:
> > > two things definitely need changing:
> > >
> > > - two symbols were removed; -DSQLITE_ENABLE_RTREE brings them back
> >
>
On 2025-02-27 18:43, Stuart Henderson wrote:
two things definitely need changing:
- two symbols were removed; -DSQLITE_ENABLE_RTREE brings them back
Right, so does --enable-rtree - would that be ok as well?
please add a BUILD_DEPENDS on lang/jimtcl so that the build environment
done
pers
On 2025/02/27 17:14, Volker Schlecht wrote:
> Here's an update to the latest sqlite3 release. With the release of 3.49.0,
> they changed to build system to something that isn't compatible with our
> CONFIGURE_STYLE=gnu anymore, so we need an explicit do-configure target now.
>
> The configuration
Here's an update to the latest sqlite3 release. With the release of 3.49.0,
they changed to build system to something that isn't compatible with our
CONFIGURE_STYLE=gnu anymore, so we need an explicit do-configure target now.
The configuration should be equivalent to the current one, and the resu
16 matches
Mail list logo
